Closed
Bug 666666
Opened 13 years ago
Closed 13 years ago
Reflect HTMLMediaElement.preload like an enumerated attribute
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #541440 -
Flags: review?(bzbarsky)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 541440 [details] [diff] [review]
Patch v1
r=me
Attachment #541440 -
Flags: review?(bzbarsky) → review+
|
||
Comment 2•13 years ago
|
||
Yay 666666 !!!!!!
|
||
Comment 3•13 years ago
|
||
Comment on attachment 541440 [details] [diff] [review]
Patch v1
Review of attachment 541440 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/html/content/test/test_bug660663.html
@@ +29,5 @@
> + []);
> +reflectLimitedEnumerated(document.createElement("audio"),
> + "preload",
> + ["none", "metadata", "auto"],
> + []);
I think that would be a better idea to create a new file instead of adding these tests here. If you want to create a test suite for attribute reflection, splitting it by element would probably be better than doing that in the same file.
Not critical, though.
|
|
||
Comment 4•13 years ago
|
||
Oh, and thank you very much for fixing that :)
|
Assignee | |
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Keywords: dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
|
||
Comment 6•13 years ago
|
||
The https://developer.mozilla.org/en/DOM/HTMLMediaElement document is up-to-date regarding this change (I fixed a small typo and the type).
I added a sentence to Firefox 8 for developers, too.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•