Closed
Bug 667295
Opened 13 years ago
Closed 13 years ago
Enable JavaScript Shell packaging only when js executable is generated
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: t.matsuu, Assigned: t.matsuu)
References
Details
(Whiteboard: fixed-in-bs)
Attachments
(1 file)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
When firefox is built on top of xulrunner, no js executable is generated during building firefox. So we should generate jsshell zip package only when js executable is generated.
And NSPR libraries are not generated when --enable-system-nspr is set. So we should add NSPR libraries only when internal NSPR is built.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #542024 -
Flags: review?(ted.mielczarek)
Updated•13 years ago
|
Assignee: general → t.matsuu
Updated•13 years ago
|
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
Comment 2•13 years ago
|
||
Comment on attachment 542024 [details] [diff] [review]
Generate JavaScript Shell packag only when js executable is generated
Review of attachment 542024 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks. I thought there might be some situation where this would break, but I couldn't think of it while reviewing the original patch.
Attachment #542024 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 3•13 years ago
|
||
Pushed to b-s:
http://hg.mozilla.org/projects/build-system/rev/bf88ac3f2316
Takanori, thanks for the patch! In the future, could you put the bug number in the changeset description? That way when someone pushes your patch for you they don't need to edit anything, they can just import it and push it.
Keywords: checkin-needed
Whiteboard: fixed-in-bs
Assignee | ||
Comment 4•13 years ago
|
||
Ted,
Thank you for letting me know.
I'll carefully check the changeset description next time.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in
before you can comment on or make changes to this bug.
Description
•