Closed
Bug 667525
Opened 13 years ago
Closed 13 years ago
Base the initial "Other" zoom level on a pref rather than a property
Categories
(SeaMonkey :: Preferences, enhancement)
SeaMonkey
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.5
People
(Reporter: rsx11m.pub, Assigned: rsx11m.pub)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
For the assumed case that bug 621823 removes the "values" property for the zoom levels in the View > Zoom menu (or independent thereof), valueOther would be the only numerical value remaining in the viewZoomOverlay.properties.
That value is identical to zoom.maxPercent, thus it could be simply taken from the pref rather than having to maintain another property value which doesn't need localization. Also, this would be a feedback to the user about the maximum zoom value that can be entered into this field.
This is against current comm-central, thus would be bitrotted by either the favored patch in bug 621823 or by bug 667529, but is trivial to unbitrot.
Attachment #542211 -
Flags: review?(neil)
Comment 2•13 years ago
|
||
It should not display the max level, it should display whatever is used right now if it's a level other then the ones listed in that menu.
KaiRo, this bug is about where to get the *initial* value for the "Other" menu entry from, it will still display whatever the user entered if that option is utilized. The patch doesn't change anything from the user's point of view if neither of the preferences are modified (valueOther==zoom.maxPercent default).
Comment 4•13 years ago
|
||
ah, ok, sorry then.
This is functionally the same patch but applies after attachment 541143 [details] [diff] [review] to simplify testing. It is also neutral relative to bug 667529.
Updated•13 years ago
|
Attachment #542211 -
Flags: review?(neil) → review+
Thanks Neil.
Push for attachment 542211 [details] [diff] [review] on trunk please, unless bug 621823 checks in first, in which case it's attachment 542931 [details] [diff] [review] instead.
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [c-n: comment #6]
Comment 7•13 years ago
|
||
Comment on attachment 542211 [details] [diff] [review]
Use zoom.maxPercent instead [Checkin: comment 7]
http://hg.mozilla.org/comm-central/rev/77c0f9cf803d
Attachment #542211 -
Attachment description: Use zoom.maxPercent instead → Use zoom.maxPercent instead [Checkin: comment 7]
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: comment #6]
Updated•13 years ago
|
Target Milestone: --- → seamonkey2.5
Updated•13 years ago
|
Attachment #542931 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•