Closed Bug 668058 Opened 13 years ago Closed 13 years ago

Add a DIR_INSTALL nsinstall shortcut, and allow $(INSTALL) to support target-specific makefiles

Categories

(MailNews Core :: Build Config, defect)

Product:
MailNews Core
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 8.0

People

(Reporter: rain1, Assigned: rain1)

References

Details

Attachments

(1 file, 1 obsolete file)

patch v2
(deleted), patch
Callek
: review+
Details | Diff | Splinter Review
Attached patch patch v1 (obsolete) (deleted) — — Splinter Review
We're going to need this to import MozMill and its dependencies into the tree. The two are related because sometimes in our case, we'd like to recursively copy over the files and not symlink it (since setuptools likes to create garbage in the srcdir). This passed try server.
Attachment #542621 - Flags: review?(kairo)
Attached patch patch v2 (deleted) — — Splinter Review
This patch checks for WINNT/OS2 the same way TEST_INSTALLER used to.
Assignee: nobody → sid.bugzilla
Attachment #542621 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #542641 - Flags: review?(kairo)
Attachment #542621 - Flags: review?(kairo)
See bug 668053 for the m-c version. I talked to Ted and he seemed happy with the idea in general.
Blocks: 656736
I'm thinking something like DIR_INSTALL might be a better name, since we might either symlink it or recursively copy it.
Callek, will you be able to review this?
Comment on attachment 542641 [details] [diff] [review] patch v2 whoever gets to it first :)
Attachment #542641 - Flags: review?(bugspam.Callek)
Ted was undecided about whether to switch to DIR_INSTALL, so I went ahead. https://hg.mozilla.org/projects/build-system/rev/aeb17d9bdc0d
Summary: Add a RECURSIVE_INSTALL nsinstall shortcut, and allow $(INSTALL) to support target-specific makefiles → Add a DIR_INSTALL nsinstall shortcut, and allow $(INSTALL) to support target-specific makefiles
Whiteboard: [fixed-in-bs]
Oops, I should have posted that to bug 668053. (Fail.)
Whiteboard: [fixed-in-bs]
I've switched over RECURSIVE_INSTALL to DIR_INSTALL locally...
Comment on attachment 542641 [details] [diff] [review] patch v2 r+ if you apply the followup of bug 670249 to c-c as well, and if you do as m-c and use DIR_INSTALL rather than RECURSIVE_INSTALL
Attachment #542641 - Flags: review?(kairo)
Attachment #542641 - Flags: review?(bugspam.Callek)
Attachment #542641 - Flags: review+
https://hg.mozilla.org/comm-central/rev/4579fdf3d436
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 8.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: