This measures time spent on enumeration. As far as I can tell .javaEnabled is the leading trigger of plugin enumeration. This should confirm it.

Comment on attachment 542953 [details] [diff] [review] raii helper Review of attachment 542953 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/Telemetry.h @@ +75,5 @@ > + > +private: > + const ID id; > + const TimeStamp start; > +}; I think this would also work with something like: template <int id> class Timer { public: Timer(): start(TimeStamp::Now()) {} ~Timer() { Accumulate(ID(id), (TimeStamp::Now() - start).ToMilliseconds()); } private: const TimeStamp start; }; In practice, with compiler optimizations, I'm not sure it would make any difference, though. (except in debug builds where we build without optimization)

Template suggestion makes using this brilliant. Thanks.

Updated with template change

Josh, I would appreciate a quick review on this. Would be good to get some wider coverage on plugin overhead in released versions in firefox(since we are merging soon)

Comment on attachment 543286 [details] [diff] [review] telemetry for addon scanning This looks fine to me, although I'd prefer Telemetry::Timer were called AutoTimer to emphasize the fact that it's RAII.

http://hg.mozilla.org/integration/mozilla-inbound/rev/3a5af9d36fb1 http://hg.mozilla.org/integration/mozilla-inbound/rev/4504b65f69db

Would be nicer if this were AutoTimer to match our RAII naming conventions.

(In reply to comment #9) > Would be nicer if this were AutoTimer to match our RAII naming conventions. ok since there are two votes, I'll change it in a followup.

(In reply to comment #9) > Would be nicer if this were AutoTimer to match our RAII naming conventions. http://hg.mozilla.org/integration/mozilla-inbound/rev/0d425ab8eb13

http://hg.mozilla.org/mozilla-central/rev/4504b65f69db http://hg.mozilla.org/mozilla-central/rev/3a5af9d36fb1 http://hg.mozilla.org/mozilla-central/rev/0d425ab8eb13