There are menu positioning problems with submenus of scrolling menus that are themselves submenus. This is due to a couple of problems: - The widget that is being used to position menus is incorrect, it's not the widget associated with the parent view of the spawning frame, but the root view of the popup window widget that contains the frame. - The root view is the client, not the screen, and better care when adding up numbers needs to be made. Patch coming.

Needed to add a 'GetWindowType' method to nsIWidget (& implement it on nsBaseWidget, it is the analog of SetWindowType) so that I can figure out when a view is the root view of a popup window. It seems that this sort of method might be useful in other places too.

+ PRBool ParentIsScrollableView(nsIView* aStartView); + PRBool ParentIsScrollableView(nsIView* aStartView) ?? and why aren't you using -u like everyone else?

How about I use whatever style of diff I like, and you mind your own business? The lines you reference represent an internal helper method.

Use diff -u, beyotch! /be

No, I prefer diff -c because I find it easier to read. As the layout/xul part of this patch cannot easily be applied (since it contains portions of another patch which has already been reviewed by pinkerton, and as a result are not posted here), I chose readability over ease of patching. I could just as easily sent out these changes via email, and this bug not existed at all. You pick.

Looks good r=rods

r=pinkerton, contingent on: - building and tested on mac (i want to see it) - removal/cleanup of |nsMacWindow::GetWindowType()|

i recind my r=pink. i tried this patch and context menus aren't correctly positioned.

W2k, fresh source this morning, runs without patching. I wanted to test out these patches. Patches still work on current tree. Applying the patch to nsMenuPopupFrame (attach_id=27305) makes me crash on gklayout.dll when opening any menu (also rightclick/contextmenu) Applying both attach_id=27305 and attach_id=23670 (nsIWidget and nsBaseWidget) makes me crash at startup in gkwidget.dll

Ignore my previous comment. After a complete clobber/rebuild it worked without crashes. The only positioning problem I see after applying this patch is that if a submenu of a scrollable menu is ‘bounced’ of the bottom of the screen, or the submenu is so large it is a scrollable submenu itself, it is positioned (one menurow?) to low. So a big scrollable submenu (larger then the height of the screen is positioned (top=1, bottom=screenheight+1, height=screenheight) instead of (top=0, bottom=screenheight). Submenu’s aligned to the bottom of the screen are aligned to (screenheight+1) instead screenheight. This seems independent of the scrolled position of the scrollable menu. Not sure my description is clear so I’ll attach two screenshots.

Throwing into .9.1 so I don't forget it. I'll investigate ajbanck's findings during that cycle.

nav triage team: marking nsbeta1+ and p3

as discussed in team meeting, moving all Nav+ team members nsbeta1+ P3 bugs from mozilla0.9.1 to mozilla0.9.2.

*** Bug 61662 has been marked as a duplicate of this bug. ***

nav triage team: Reassigning to pchen who has a 0.9.1 bug that uses this patch. Will mark this fixed once that bug is checked in.

Oooops, I checked this fix in for mozilla0.9.1.