Closed
Bug 668893
Opened 13 years ago
Closed 13 years ago
Sort about:memory items of type COUNT alphabetically
Categories
(Toolkit :: about:memory, defect)
Toolkit
about:memory
Tracking
()
RESOLVED
FIXED
People
(Reporter: justin.lebar+bug, Assigned: n.nethercote)
Details
(Whiteboard: [inbound])
Attachments
(1 file)
(deleted),
patch
|
justin.lebar+bug
:
review+
taras.mozilla
:
feedback+
|
Details | Diff | Splinter Review |
Split off from bug 657115 comment 38: > 764,691 -- soft-page-faults > 6,602 -- webgl-buffer-count > 35 -- webgl-texture-count > 27 -- hard-page-faults > 4 -- webgl-context-count This is unrelated to this bug... sorting the "counts" events by size doesn't seem useful, alphabetical order would be better. In which case, hard-page-faults and soft-page-faults would be better renamed as page-faults-hard and page-faults-soft.
Assignee | ||
Updated•13 years ago
|
Component: General → about:memory
QA Contact: general → about.memory
Assignee | ||
Comment 2•13 years ago
|
||
This patch changes the sort ordering and renames the page fault reporters. Sample output: Other Measurements 604,733,440 B -- vsize 84,688,896 B -- resident 42,991,616 B -- heap-committed 39,926,938 B -- heap-used 8,388,608 B -- js-gc-heap 3,063,044 B -- heap-unused 430,080 B -- heap-dirty 48,320 B -- gfx-surface-image 31 -- page-faults-hard 22,109 -- page-faults-soft Taras, will changing the name of a reporter cause problems for telemetry?
Assignee: nobody → nnethercote
Attachment #544112 -
Flags: review?(justin.lebar+bug)
Attachment #544112 -
Flags: feedback?(tglek)
Updated•13 years ago
|
Attachment #544112 -
Flags: feedback?(tglek) → feedback+
Reporter | ||
Comment 3•13 years ago
|
||
Comment on attachment 544112 [details] [diff] [review] patch > // Compare two memory reporter nodes. We want to group together measurements > // with the same units, so sort first by the nodes' _units field, then sort by >-// the amount if the units are equal. >+// the amount if the units are equal. Also, sort UNIT_COUNTS reporters in >+// alphabetical order by path, because that gives the best looking output. Nit: Rewrite this comment so it's consistent. Perhaps: ... sort first by the nodes' _units field. If the node has _units equal to UNITS_COUNT, sort second by the node's _path, ascending. Otherwise, sort by the node's _amount, descending.
Attachment #544112 -
Flags: review?(justin.lebar+bug) → review+
Assignee | ||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/7b51d251e2bd
Whiteboard: [inbound]
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/7b51d251e2bd
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•