Closed
Bug 668969
Opened 13 years ago
Closed 13 years ago
Empty mfenced elements should display fences
Categories
(Core :: MathML, defect)
Core
MathML
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: fs, Assigned: fs)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
(Follow-up of bug 553918 comment1)
Testsuite test: http://www.w3.org/Math/testsuite/build/main/Presentation/GeneralLayout/mfenced/mfenced1-full.xhtml
I already provided a reftest which currently fails (mfenced-9): https://bug553918.bugzilla.mozilla.org/attachment.cgi?id=543487
Perhaps we can just remove the if statement here?
http://mxr.mozilla.org/mozilla-central/source/layout/mathml/nsMathMLmfencedFrame.cpp#354
Comment 1•13 years ago
|
||
> Perhaps we can just remove the if statement here?
> http://mxr.mozilla.org/mozilla-central/source/layout/mathml/
> nsMathMLmfencedFrame.cpp#354
Yes, I think I will work. We just have to verified that we won't use null Frame pointer or similar.
Assignee | ||
Comment 2•13 years ago
|
||
Comment 3•13 years ago
|
||
(In reply to comment #2)
> Created attachment 543603 [details] [diff] [review] [review]
> Fix: Removes the if condition
Did you test it? I think I read it too quickly this morning, and thought this if statement was to leave the function when the mfenced is empty.
Comment 4•13 years ago
|
||
Comment on attachment 543603 [details] [diff] [review]
Fix: Removes the if condition
Yes, I agree that the empty mfenced should not be handled specially here.
The centering logic happens to provide additional size so that the fences become visible. This is still not quite exactly how they should be, but is definitely better.
The height of the fences should be considered in containerSize and I don't see
that happening. This might be a regression from bug 414277, because, before then, characters were always stretched to at least their base size.
This patch is at least part of the solution and good enough for this bug.
Attachment #543603 -
Flags: review?(karlt) → review+
Updated•13 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•13 years ago
|
||
Filed bug 670334 to follow-up the height issue.
Comment 6•13 years ago
|
||
Keywords: checkin-needed
Whiteboard: [inbound]
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Version: unspecified → Trunk
Comment 8•13 years ago
|
||
Is this tested with tests in bug 553918?
Comment 9•13 years ago
|
||
(In reply to comment #8)
> Is this tested with tests in bug 553918?
Yes, it is.
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•