Closed
Bug 669062
Opened 13 years ago
Closed 13 years ago
Starring doesn't work
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
Swatinem
:
review+
|
Details | Diff | Splinter Review |
There were two bugs here:
1. NetUtils.crossDomainPost was using arguments.callee, but accessing that is
an error in strict mode.
2. AddCommentsUI.js was passing a field called "machinename" but
submitBuildStar.php was expecting it to be named "machineName".
I've fixed crossDomainPost by removing it and using $.ajax instead.
Attachment #543670 -
Flags: review?(arpad.borsos)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 543670 [details] [diff] [review]
v1
Review of attachment 543670 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #543670 -
Flags: review?(arpad.borsos) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Comment 3•13 years ago
|
||
This seems to work - anything left to do here?
|
|
Assignee | |
Comment 4•13 years ago
|
||
No, this is done. I haven't resolved the bug yet because the change hasn't been deployed to tbpl.mozilla.org yet (bug 669000).
Starring on tbpl.mozilla.org still works because this bug was never present there. The changes that caused it haven't been deployed to tbpl.mozilla.org.
|
||
Comment 5•13 years ago
|
||
And now both bits have been, despite it having taken a rather odd route around through bug 683241 to production.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Webtools → Tree Management
|
|
||
Updated•10 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•