Closed
Bug 669072
Opened 13 years ago
Closed 13 years ago
Display results regardless of notes loading failure
Categories
(Tree Management Graveyard :: TBPL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Swatinem, Assigned: Swatinem)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #543675 -
Flags: review?(mstange)
|
||
Comment 1•13 years ago
|
||
Why would that work? If starcomment.php is 404, then we wouldn't end up in the success callback at all, would we?
|
Assignee | |
Comment 2•13 years ago
|
||
Hm it is for the case that we are in the sucess callback but the notes array is not an array but actually an object with {error: ...}
|
|
Assignee | |
Comment 3•13 years ago
|
||
But you are right, it should handle both cases.
Attachment #543675 -
Attachment is obsolete: true
Attachment #543677 -
Flags: review?(mstange)
Attachment #543675 -
Flags: review?(mstange)
|
|
||
Updated•13 years ago
|
Attachment #543677 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Deployed via bug 683241.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Webtools → Tree Management
|
|
||
Updated•10 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•