Closed Bug 669108 Opened 13 years ago Closed 13 years ago

Public crash reports should display TotalVirtualMemory, AvailableVirtualMemory, SystemMemoryUsePercentage, AvailablePageFile, and AvailablePhysicalMemory

Categories

(Socorro :: Webapp, task)

task
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jwatt, Assigned: laura)

References

Details

Attachments

(1 file)

Right now to get information on the memory use (the fields TotalVirtualMemory, AvailableVirtualMemory and SystemMemoryUsePercentage...on Mac at least) at the time of a crash you need someone with admin access to crash-stats.mozilla.com to get that for you. This info should just be available on the public reports. If someone can point me to the parts of the code that need patched I'd be happy to have a go at fixing this.
There must be a reason, probably privacy or security concerns, why we hide those right now. Is there such a risk with that data? How large is it?
I don't believe there's any reason, there's no privacy risk to exposing this data AFAICT. I think we just treat all data from the client as private-by-default unless we explicitly make it public in the Socorro code.
Component: Socorro → General
Product: Webtools → Socorro
Component: General → Webapp
Also please publicly report the field "OOMAllocationSize", which I just added in bug 716638. It will not be present in all reports.
Laura, this looks relatively easy and would be a big win for a bunch of people looking at our OOM crashes and bugs, is it possible to get this prioritized?
While we're piling on here, it would be great to get AvailablePageFile and AvailablePhysicalMemory (bug 720444) added as well.
Summary: Public crash reports should display TotalVirtualMemory, AvailableVirtualMemory and SystemMemoryUsePercentage → Public crash reports should display TotalVirtualMemory, AvailableVirtualMemory, SystemMemoryUsePercentage, AvailablePageFile, and AvailablePhysicalMemory
Unless we're concerned about fingerprinting on Available{PhysicalMemory,PageFile}? It seems that you'd be able to fingerprint much better with e.g. the list of add-ons.
Lars, I don't think we have those in the processed json so you'll need to make a processor change first.
Assignee: nobody → lars
Target Milestone: --- → 2.4.2
We need to get access to the the raw json in the UI to solve this.
Assignee: lars → laura
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/8735569798967b0b91898ee7b4b8e3ab542aa63b Bug 669108 - forgot OOMAllocationSize added here https://github.com/mozilla/socorro/commit/49b4bdad598df7ff9a899c9d3cc3abfbcaf289f1 Merge pull request #333 from lauraxt/669108 Fixes bug 669108, add some more stuff from the raw JSON to the UI. Also added better error checking.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Attached image qa - verified (deleted) —
Thank you mightily :rhelmer for submitting a crash to stage for verification purposes. https://crash-stats.allizom.org/report/index/8331e757-0eee-43ba-9ad8-037c52120210 Bumping to QA verified on stage. The following fields are no present on crash reports: TotalVirtualMemory AvailableVirtualMemory SystemMemoryUsePercentage AvailablePageFile AvailablePhysicalMemory OOMAllocationSize
Status: RESOLVED → VERIFIED
Yes, TotalVirtualMemory, AvailableVirtualMemory, SystemMemoryUsePerce are now visible on crash reports.
We should probably get a followup to format these better, or at least add units. (They're all bytes, except for System Memory Use Percentage, which is obviously a percentage.)
Depends on: 720444, 716638, 493779
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: