Open
Bug 669119
Opened 13 years ago
Updated 2 years ago
Consider dropping spell checker hash on memory-pressure notification
Categories
(Core :: Spelling checker, defect)
Core
Spelling checker
Tracking
()
NEW
People
(Reporter: justin.lebar+bug, Unassigned)
References
Details
(Whiteboard: [MemShrink:P3])
In bug 669116, njn says that we instantiate the spellchecker lazily, but never get rid of it.
I don't know how expensive it would be to drop the spellchecker and re-initialize it later, and it's apparently less than 3mb, but if it's an easy thing to do, perhaps we should do it.
We want to release as much memory as possible on mobile when we get a memory-pressure notification, because doing so increases the chance that the OS will keep us alive after we're minimized.
These things add up...
Reporter | ||
Updated•13 years ago
|
Whiteboard: [MemShrink]
Comment 1•13 years ago
|
||
Do we have spellchecker on mobile?
Comment 2•13 years ago
|
||
(In reply to comment #1)
> Do we have spellchecker on mobile?
No.
Updated•13 years ago
|
Blocks: MatchStartupMem
Updated•13 years ago
|
No longer blocks: MatchStartupMem
Whiteboard: [MemShrink] → [MemShrink:P3]
Updated•13 years ago
|
Blocks: MatchStartupMem
Comment 3•13 years ago
|
||
Given that we now know that the spell checker uses ~4MB of memory, do we still want to do this?
Comment 4•13 years ago
|
||
I think so; 4MB isn't small, esp. on mobile.
Comment 5•13 years ago
|
||
(In reply to Nicholas Nethercote [:njn] (on vacation Sep 12--Oct 17) from comment #4)
> I think so; 4MB isn't small, esp. on mobile.
Spell checker is disabled on Mobile currently. Is that something that we would want to enable in the future?
Comment 6•13 years ago
|
||
(In reply to Ehsan Akhgari [:ehsan] from comment #5)
> (In reply to Nicholas Nethercote [:njn] (on vacation Sep 12--Oct 17) from
> comment #4)
> > I think so; 4MB isn't small, esp. on mobile.
>
> Spell checker is disabled on Mobile currently. Is that something that we
> would want to enable in the future?
It's possible, especially with tablets giving us more UI "space" for context menu options
Comment 7•13 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #6)
> (In reply to Ehsan Akhgari [:ehsan] from comment #5)
> > (In reply to Nicholas Nethercote [:njn] (on vacation Sep 12--Oct 17) from
> > comment #4)
> > > I think so; 4MB isn't small, esp. on mobile.
> >
> > Spell checker is disabled on Mobile currently. Is that something that we
> > would want to enable in the future?
>
> It's possible, especially with tablets giving us more UI "space" for context
> menu options
Is there a bug on that? We can make this one block that bug. This would probably require a bit of hunspell surgery, which is not easy, so I don't want to spend time on it unless we're actually going to get something out of it.
Comment 8•13 years ago
|
||
(In reply to Ehsan Akhgari [:ehsan] from comment #7)
> (In reply to Mark Finkle (:mfinkle) from comment #6)
> > (In reply to Ehsan Akhgari [:ehsan] from comment #5)
> > > Spell checker is disabled on Mobile currently. Is that something that we
> > > would want to enable in the future?
> >
> > It's possible, especially with tablets giving us more UI "space" for context
> > menu options
>
> Is there a bug on that? We can make this one block that bug. This would
> probably require a bit of hunspell surgery, which is not easy, so I don't
> want to spend time on it unless we're actually going to get something out of
> it.
No bug yet. Until there is, I wouldn't block on mobile.
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•