Closed
Bug 669886
Opened 13 years ago
Closed 13 years ago
Make nsMappedAttributeElement, nsStyledElement, nsStyledElementNotElementCSSInline, nsGenericHTMLElement, nsGenericHTMLFormElement and nsGenericHTMLFrameElement participate in DOM Memory Reporter
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
I will probably have to make nsFrameLoader participate in DOM Memory Reporter too in another patch.
Attachment #544472 -
Flags: review?(jst)
|
||
Updated•13 years ago
|
Attachment #544472 -
Flags: review?(jst) → review+
|
||
Comment 1•13 years ago
|
||
Comment on attachment 544472 [details] [diff] [review]
Patch v1
>--- a/content/html/content/src/nsGenericHTMLElement.cpp
>+++ b/content/html/content/src/nsGenericHTMLElement.cpp
>+nsGenericHTMLFrameElement::SizeOf() const
>+{
>+ PRInt64 size = MemoryReporter::GetBasicSize<nsGenericHTMLFrameElement,
>+ nsGenericHTMLElement>(this);
>+ // TODO: might need to implement SizeOf() in nsFrameLoader.
>+ size += mFrameLoader ? sizeof(*mFrameLoader.get()) : 0;
Do you need the .get()?
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs review] → [inbound]
|
||
Comment 2•13 years ago
|
||
this has been backed out by ehsan due to bustage with all the other changesets in the same push
Whiteboard: [inbound]
|
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•