Closed
Bug 670003
Opened 13 years ago
Closed 13 years ago
[OS/2] update Yarr files
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: wuno, Assigned: dave.r.yeo)
References
Details
(Whiteboard: tracemonkey)
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
Dave has made an initial patch to update Yarr for OS/2
|
Reporter | |
Updated•13 years ago
|
Attachment #544617 -
Attachment is patch: true
Attachment #544617 -
Attachment mime type: message/rfc822 → text/plain
|
|
Reporter | |
Updated•13 years ago
|
Assignee: general → daveryeo
Status: NEW → ASSIGNED
|
||
Comment 1•13 years ago
|
||
Is the patch ready for review?
(In reply to comment #1)
> Is the patch ready for review?
Testing an updated patch, will ask you for review after testing
Blocks: 625600
Attachment #544617 -
Attachment is obsolete: true
Attachment #545007 -
Flags: review?(dmandelin)
After some feedback from Rich patch updated with better commit and decommit plus a simplification of protection()
Attachment #545007 -
Attachment is obsolete: true
Attachment #545089 -
Flags: review?(dmandelin)
Attachment #545007 -
Flags: review?(dmandelin)
|
|
||
Comment 5•13 years ago
|
||
Comment on attachment 545089 [details] [diff] [review]
Update Yarr to work on OS/2
Review of attachment 545089 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/yarr/PageBlock.cpp
@@ +58,5 @@
> +{
> + return getpagesize();
> +}
> +
> +#elif WTF_OS_OS2
One question: any reason not to just use
#if (WTF_OS_UNIX && !WTF_OS_SYMBIAN) || WTF_OS_OS2
above?
(In reply to comment #5)
> Comment on attachment 545089 [details] [diff] [review] [review]
> Update Yarr to work on OS/2
>
> Review of attachment 545089 [details] [diff] [review] [review]:
> -----------------------------------------------------------------
>
> ::: js/src/yarr/PageBlock.cpp
> @@ +58,5 @@
> > +{
> > + return getpagesize();
> > +}
> > +
> > +#elif WTF_OS_OS2
>
> One question: any reason not to just use
>
> #if (WTF_OS_UNIX && !WTF_OS_SYMBIAN) || WTF_OS_OS2
>
> above?
I meant to fix this and forgot. Updated patch attached
Attachment #545089 -
Attachment is obsolete: true
Attachment #545319 -
Flags: review?(dmandelin)
Attachment #545089 -
Flags: review?(dmandelin)
|
|
||
Comment 7•13 years ago
|
||
Comment on attachment 545319 [details] [diff] [review]
Update Yarr to work on OS/2
Review of attachment 545319 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #545319 -
Flags: review?(dmandelin) → review+
|
|
Reporter | |
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: tracemonkey
|
||
Comment 8•13 years ago
|
||
Keywords: checkin-needed
Whiteboard: tracemonkey → tracemonkey [inbound]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
||
Comment 9•13 years ago
|
||
(Technically, bugs aren't FIXED until their patches make it into mozilla-central. That should happen for this bug in the next day or so, at the next merge from mozilla-inbound. Whoever merges mozilla-inbound to mozilla-central will resolve this bug.)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Updated•13 years ago
|
Status: REOPENED → ASSIGNED
|
||
Comment 10•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Whiteboard: tracemonkey [inbound] → tracemonkey
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•