Closed
Bug 670564
Opened 13 years ago
Closed 13 years ago
"ASSERTION: illegal left edge" in nsDisplayText::Paint
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: jruderman, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: assertion, testcase)
Attachments
(2 files)
(deleted),
application/xhtml+xml
|
Details | |
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: illegal left edge: 'mLeftEdge >= 0', file layout/generic/nsTextFrameThebes.cpp
Assignee | ||
Comment 1•13 years ago
|
||
Leading up to the reported assertion (on Linux64):
WARNING: Overflowed nscoord_MAX in conversion to nscoord: 'aValue <= nscoord_MAX', file ../../dist/include/nsCoord.h, line 106
nsLineLayout: Text(0)@0x7ff67d230f10 metrics=1073741824,1140!
###!!! ASSERTION: Computed overflow area must contain frame bounds: 'aNewSize.width == 0 || aNewSize.height == 0 || aOverflowAreas.Overflow(otype).Contains(nsRect(nsPoint(0,0), aNewSize))', file layout/generic/nsFrame.cpp, line 6465
###!!! ASSERTION: Wrong bounds: 'bounds.IsEqualInterior(aChildren.GetBounds(aBuilder))', file layout/base/FrameLayerBuilder.cpp, line 1838
###!!! ASSERTION: illegal left edge: 'mLeftEdge >= 0', file layout/generic/nsTextFrameThebes.cpp, line 4179
OS: Mac OS X → All
Assignee | ||
Comment 2•13 years ago
|
||
The "illegal left edge" assertion was added in bug 312156.
The condition is quite harmless.
Assignee | ||
Comment 3•13 years ago
|
||
The distance to the marker edge is so large it causes integer overflow
on nscoord. I think we can safely assume all of it is clipped (the
the width would have to be > nscoord_MAX to be visible).
Attachment #545146 -
Flags: review?(roc)
Comment on attachment 545146 [details] [diff] [review]
fix + crashtest
Review of attachment 545146 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #545146 -
Flags: review?(roc) → review+
Assignee | ||
Comment 5•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/21d1ecfeabd8
http://hg.mozilla.org/integration/mozilla-inbound/rev/94bf463e0040
Flags: in-testsuite+
Whiteboard: [inbound]
Comment 6•13 years ago
|
||
Merged:
http://hg.mozilla.org/mozilla-central/rev/21d1ecfeabd8
http://hg.mozilla.org/mozilla-central/rev/94bf463e0040
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•