Closed
Bug 670962
Opened 13 years ago
Closed 13 years ago
Make nsGenericDOMDataNode and nsTextFragment participate to the DOM Memory Reporter
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #545397 -
Flags: review?(jst)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 545397 [details] [diff] [review]
Patch v1
- In nsTextFragment::SizeOf():
+ PRInt64 size = sizeof(*this);
+ size += GetLength() * Is2b() ? sizeof(*m2b) : sizeof(*m1b);
We should only add the size of the text itself if mState.mInHeap is true, if not, it's a text fragment that points to a shared static whitespace string.
r=jst with that.
Attachment #545397 -
Flags: review?(jst) → review+
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs review] → [inbound]
|
||
Comment 2•13 years ago
|
||
this has been backed out by ehsan due to bustage with all the other changesets in the same push
Whiteboard: [inbound]
|
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•