Closed
Bug 671533
Opened 13 years ago
Closed 13 years ago
test_DownloadUtils.js fails when system locale doesn't use the dot as a decimal separator
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Mardak
:
review+
|
Details | Diff | Splinter Review |
TEST-UNEXPECTED-FAIL | /mnt/_tests/xpcshell/toolkit/mozapps/downloads/tests/unit/test_DownloadUtils.js | A few seconds remaining 2,3 of 2,4 KB (58 bytes/sec) == A few seconds remaining 2.3 of 2.4 KB (58 bytes/sec) - See following stack:
(...)
(This also means that our lack of running tests on non en-US locales may hide subtle problems that our unit tests are supposed to catch but don't)
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #545890 -
Flags: review?(edilee)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 545890 [details] [diff] [review]
Fix test_DownloadUtils.js with locales with a different decimal separator
Could be useful to add a test for explicitly checking two decimal replacement even though the testStatuses already have strings that have two decimals.
114 testTransferTotal(234, 4924, _("234 bytes of 4.8 KB"));
115 testTransferTotal(94923, 233923, _("92.7 of 228 KB"));
+ testTransferTotal(4924, 94923, _("4.8 KB of 92.7"));
Attachment #545890 -
Flags: review?(edilee) → review+
|
|
||
Comment 3•13 years ago
|
||
(In reply to comment #2)
> + testTransferTotal(4924, 94923, _("4.8 KB of 92.7"));
Er. Should probably be
testTransferTotal(4924, 94923, _("4.8 of 92.7 KB"));
|
|
Assignee | |
Comment 4•13 years ago
|
||
Assignee: nobody → mh+mozilla
Whiteboard: [inbound]
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•