Closed
Bug 671550
Opened 13 years ago
Closed 13 years ago
provide correct parent HWND for content process window
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: surkov, Assigned: surkov)
References
Details
(Keywords: access, Whiteboard: [e10s])
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
JAWS doesn't work still, though it should, WM_GETOBJECT is handled, events are fired, get_accChild works. How can I get a try build on electrolysis branch to share?
Comment 1•13 years ago
|
||
Just push to try.
Assignee | ||
Updated•13 years ago
|
Whiteboard: [e10s]
Assignee | ||
Comment 2•13 years ago
|
||
(In reply to comment #1) > Just push to try. Does it really build on electrolysis branch? I get build errors.
Comment 3•13 years ago
|
||
All the relevant patches from electrolysis have been pushed to mozilla-central, you can just use m-c now.
Assignee | ||
Comment 4•13 years ago
|
||
Attachment #545908 -
Attachment is obsolete: true
Attachment #547082 -
Flags: review?(jones.chris.g)
Assignee | ||
Updated•13 years ago
|
Attachment #547082 -
Flags: review?(bolterbugz)
Comment 5•13 years ago
|
||
Comment on attachment 547082 [details] [diff] [review] patch2 Review of attachment 547082 [details] [diff] [review]: ----------------------------------------------------------------- r=me. As far as I can tell we don't need to worry about config options here right? ::: accessible/src/msaa/nsDocAccessibleWrap.cpp @@ +281,5 @@ > nsRootAccessible* rootDocument = RootAccessible(); > > + void* nativeData = nsnull; > + if (tabChild) > + tabChild->SendGetWidgetNativeData(&nativeData); What about "SendGetWidgetHwnd"? @@ +300,5 @@ > docShell->GetIsActive(&isActive); > } > > + HWND parentWnd = static_cast<HWND>(nativeData); > + //HWND parentWnd = static_cast<HWND>(rootDocument->GetNativeWindow()); remove comment.
Attachment #547082 -
Flags: review?(bolterbugz) → review+
Comment on attachment 547082 [details] [diff] [review] patch2 Serializing voidPtr is overly general and misleading, so we've avoided it so far. In bug 648484, we also need to serialize HWNDs and added a "WindowsHandle" helper thusly diff --git a/ipc/glue/IPCMessageUtils.h b/ipc/glue/IPCMessageUtils.h --- a/ipc/glue/IPCMessageUtils.h +++ b/ipc/glue/IPCMessageUtils.h @@ -68,16 +68,20 @@ namespace base { class FileDescriptor { using mozilla::layers::LayerManager; namespace mozilla { typedef gfxPattern::GraphicsFilter GraphicsFilterType; typedef gfxASurface::gfxSurfaceType gfxSurfaceType; typedef LayerManager::LayersBackend LayersBackend; +typedef gfxASurface::gfxImageFormat PixelFormat; +// This is a cross-platform approximation to HANDLE, which we expect +// to be typedef'd to void* or thereabouts. +typedef uintptr_t WindowsHandle; so that your protocol have have |using mozilla::WindowsHandle;|. That bug has been backed out twice now :/, but I'd prefer you borrow that snipped instead of using voidPtr.
Assignee | ||
Comment 7•13 years ago
|
||
Attachment #547082 -
Attachment is obsolete: true
Attachment #547441 -
Flags: review?(jones.chris.g)
Attachment #547082 -
Flags: review?(jones.chris.g)
Updated•13 years ago
|
Attachment #547441 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Comment 8•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/f1d496722775
Whiteboard: [e10s] → [e10s][inbound]
Comment 9•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/f1d496722775
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [e10s][inbound] → [e10s]
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•