From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux 2.4.0-test10 i686; en-US; m18) Gecko/20010126 BuildID: 2001012611 When you type an URL that goes directly to an image, or click on it, and mozilla is configured to ask before loading an image, it asks me, even if it's obvious that the answer is "yes". Reproducible: Always Steps to Reproduce: 1. Enable asking before loading an image 2. Make sure www.cert.com isn't in your list of allowed image sites 3. Open the URL Actual Results: Mozilla asks "www.cert.com wants to load an image, are you sure?" Expected Results: Figured out that since the image is the main page and not a page component I obviously wanted to load it.

That should be www.cert.org, right? =)

Oops sorry for that :P

If that image is a full page, then Mozilla won't ask you that, but for smaller images it does. At least I have seen something in the source! BTW, would you like to make this an RFE, Request For Enhancement? If yes, please set Severity to Enhancement. Thank you.

H-J is right. That code is in modulules/libimg/scr/if.cpp. Search for the comment: Check to see if the image is the whole page, in which case accept it If this is not working, then it's a bug in this code, not a request for enhancement. Could this be a dup of bug 34165? Note in particular my comment of 2000-06-09 09:18 that I posted in that report.

Morse, should it work like this? if image < current window size, ask to confirm image load if image => current window size, then accept without the confirm message

if current window < image.gif then it always asks me to confirm if image > current screen resolution then it always asks me to confirm uses .gif .jpg and .png images. So now confirming bug on WinNT4 build 20010122/29

H-J, no it has nothing to do with the size of the image relative to the size of the current window. We should ask to confirm unless the url requested is the image itself.

Just took a look in the source, and that's not the case. It should always prevent the message. Morse, it seems it a bug. Morse, it seems that my last comment is incorrect. Mozilla should prevent asking the confirm message, if the first load is an image, right?

Oops, sorry Morse, I did not expect you to be that fast. I just didn't look before inserting my last comments.

Marking NEW as per comments.

A bit hard to test without image blocking working, uh?

->pavlov?

the code that would pop up this box should not be getting called right now. morse, any idea why the code is getting hit? is there something watching loads of urls that is intercepting image loads ?

Currently the pop-up box is not coming up because of the restructuring that was recently done to imagelib (see bug 73848). Because of that restructuring, image loading is no longer going through the code in if.cpp and that was what was triggering the pop-up. However it has been observed that certain images are still going through if.cpp and hence getting the pop-up. It wasn't at all obvious why some images were still taking this path whereas most other images were not. Then in bug 77331, peterj made the discovery that images from stylesheets were the ones still getting the pop-up whereas images in html pages were not. This should answer pav's question about why the code is still getting hit.

Is this resolved by bug 110112?

Reassigning Image Manager bugs to mstoltz and clearing milestone.

This bug was accidentally marked security-sensitive yesterday. Removing security-sensitive status now.

This is basically bug 34165 and will be fixed as such. *** This bug has been marked as a duplicate of 34165 ***

I'm not so sure it's a dupe; bug 34165 is about the View Image menu item, this one is about simply following a link directly to an image. If I'm wrong and bug 34165 is also about following a link to a blocked image, please mark as a duplicate again.

The easiest way to see if it is a dup would be to see if it is fixed now. And so I did. And now when i block images from test.localdomain, and then click on a link to test.localdomain/warning.gif, the image appears, just like when selecting "view image" from the context menu. Marking as dup. *** This bug has been marked as a duplicate of 34165 ***