Closed
Bug 672756
Opened 13 years ago
Closed 13 years ago
GENERATE_CACHE in Firefox failed when building it on top of xulrunner
Categories
(Toolkit Graveyard :: Build Config, defect)
Toolkit Graveyard
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla8
People
(Reporter: t.matsuu, Assigned: glandium)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Building firefox is failed when it is built on top of xulrunner.
+++ Failed to get ScriptSecurityManager service, running without principals/bin/sh: line 1: 21824 Segmentation fault (core dumped) /media/bkup/work/rpmbuild/BUILD/firefox-8.0/mozilla-central/browser/installer/../../dist/bin/run-mozilla.sh /usr/lib64/xulrunner-sdk-8/bin/xpcshell -g "$PWD" -a "$PWD" -f ../../toolkit/mozapps/installer/precompile_cache.js -e 'populate_startupcache("omni.jar", "startupCache.zip");'
make[1]: *** [install] Error 139
Reporter | ||
Comment 1•13 years ago
|
||
To escape this issue, attachment 515715 [details] [diff] [review] in bug 633645 is reverted in the Red Hat version of Firefox 5 RPM package.
Reporter | ||
Updated•13 years ago
|
Assignee: nobody → mh+mozilla
Reporter | ||
Comment 2•13 years ago
|
||
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to comment #2)
> Created attachment 547028 [details] [diff] [review] [review]
> Tentative fix
That's a workaround. But I think we should come up with an actual fix. I know how to do it.
Depends on: 655678
Assignee | ||
Comment 4•13 years ago
|
||
Attachment #551031 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•13 years ago
|
Component: XULRunner → Build Config
OS: Linux → All
QA Contact: xulrunner → build-config
Hardware: x86_64 → All
Assignee | ||
Updated•13 years ago
|
Attachment #547028 -
Attachment is obsolete: true
Assignee | ||
Comment 5•13 years ago
|
||
This will need to be refreshed after bug 674352. I hope this doesn't break thunderbird and seamonkey...
Reporter | ||
Comment 6•13 years ago
|
||
Works fine for me.
And attachment 550523 [details] [diff] [review] in bug 674352 is checked into mozilla-inbound.
Comment 7•13 years ago
|
||
Comment on attachment 551031 [details] [diff] [review]
Allow to populate startupcache on xulrunner applications built with the SDK
Review of attachment 551031 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/mozapps/installer/packager.mk
@@ +390,5 @@
> _ABS_RUN_TEST_PROGRAM = $(call core_abspath,$(RUN_TEST_PROGRAM))
> endif
>
> +ifdef LIBXUL_SDK
> +PRECOMPILE_PROP=XCurProcD
I could probably call this PRECOMPILE_DIR or something. "PROP" isn't very descriptive.
Attachment #551031 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 8•13 years ago
|
||
Whiteboard: [inbound]
Assignee | ||
Comment 9•13 years ago
|
||
Backed out
http://hg.mozilla.org/integration/mozilla-inbound/rev/22af0a57b683
RUN_TEST_PROGRAM doesn't point to something that exists when in js/src.
Whiteboard: [inbound]
Assignee | ||
Comment 10•13 years ago
|
||
Sometimes, keeping config/config.mk and js/src/config/config.mk in sync hurts :(
Attachment #553126 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•13 years ago
|
Attachment #551031 -
Attachment is obsolete: true
Comment 11•13 years ago
|
||
Comment on attachment 553126 [details] [diff] [review]
Allow to populate startupcache on xulrunner applications built with the SDK
Review of attachment 553126 [details] [diff] [review]:
-----------------------------------------------------------------
::: config/config.mk
@@ +747,3 @@
> else
> ifneq (WINNT,$(OS_ARCH))
> +RUN_TEST_PROGRAM = $(if $(LIBXUL_DIST),$(LIBXUL_DIST),$(DIST))/bin/run-mozilla.sh
You can just use $(LIBXUL_DIST) unconditionally here, since it defaults to $(DIST).
Attachment #553126 -
Flags: review?(ted.mielczarek) → review+
Comment 12•13 years ago
|
||
As glandium points out, LIBXUL_DIST is not set in js/src, which is the whole reason this is broken. I suggested perhaps in config.mk setting LIBXUL_DIST ?= $(DIST)
Assignee | ||
Comment 13•13 years ago
|
||
Whiteboard: [inbound]
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•