Closed
Bug 672938
Opened 13 years ago
Closed 13 years ago
Make pythonpath.py work better with pymake native commands
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla8
People
(Reporter: khuey, Assigned: khuey)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
This means corralling the functionality into a 'main' method that we can call.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #547244 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #547244 -
Attachment is obsolete: true
Attachment #547429 -
Flags: review?(ted.mielczarek)
Attachment #547244 -
Flags: review?(ted.mielczarek)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 547429 [details] [diff] [review]
Patch
Review of attachment 547429 [details] [diff] [review]:
-----------------------------------------------------------------
::: build/tests/test_expressionparser.txt
@@ +9,5 @@
>
> Test basic values::
>
> >>> parse("1")
> + 4
You're going to want to leave this out when you land this patch. :)
::: config/pythonpath.py
@@ +43,5 @@
> +
> + execfile(script, frozenglobals)
> +
> +# Freeze scope here ... why this makes things work I have no idea ...
> +frozenglobals = globals()
This is a little goofy, but I'm sure there's a reasonable explanation. I would like to know what it is, but I'm not going to block you on landing this.
Attachment #547429 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•