Closed
Bug 673003
Opened 13 years ago
Closed 13 years ago
Handle \\\n in pymake
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: khuey, Assigned: khuey)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
In http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/9de1d1f4e4b1 bsmedberg blocklisted '\\\n'. I'm not a shell expert, but we can just strip that out, right?
It's going to be pretty annoying if we have to mash all of our pymake native commands onto one line.
Attachment #547297 -
Flags: review?(benjamin)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 547297 [details] [diff] [review]
Patch?
Review of attachment 547297 [details] [diff] [review]:
-----------------------------------------------------------------
The code looks fine, but you really need to add some tests. r=me with tests.
Attachment #547297 -
Flags: review?(benjamin) → review+
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•