Currently jemalloc requires VC8/9 pro or VC10. It should be possible to enable new-style jemalloc on VC8/9 express too.

This patch searches for the VC8/9 source. Only if it doesn't find it does it use the new-style jemalloc. This means that it doesn't affect Tinderbox. Because of the crtdll check, this actually works on debug VC8/9 express builds and debug and opt Windows SDK 6/7/7.1 x86/x64 builds too. (Well, SDK 6 is currently broken for other reasons...)

Comment on attachment 547466 [details] [diff] [review] Proposed patch [Checked in: See comment 13] Awesome stuff.

Pushed changeset 83ef35b794ce to mozilla-central.

Backed out: http://hg.mozilla.org/mozilla-central/rev/a627b24e684e

vc10 jemalloc build has been collapsed after back out.

if use -MANIFEST:NO, vc8/9 build crashes. vc10 is no probrem without -MANIFEST:NO.

(In reply to comment #6) > if use -MANIFEST:NO, vc8/9 build crashes. > vc10 is no probrem without -MANIFEST:NO. vc8/9 build shouldn't be using that line.

Comment on attachment 549626 [details] [diff] [review] fix back out misstake [Checked in: Comment 11] Oops, thanks for spotting this!

(In reply to comment #7) > (In reply to comment #6) > > if use -MANIFEST:NO, vc8/9 build crashes. > > vc10 is no probrem without -MANIFEST:NO. > > vc8/9 build shouldn't be using that line. sorry, vc8/9 **express** jemalloc build crashes.

(In reply to comment #8) > Comment on attachment 549626 [details] [diff] [review] [diff] [details] [review] > fix back out misstake. > > Oops, thanks for spotting this! thanks. this patch solves Bug 674972.

(In reply to comment #10) > (In reply to comment #8) > > Oops, thanks for spotting this! > > thanks. > this patch solves Bug 674972. Pushed changeset f92e021f1f44 to mozilla-central. (In reply to comment #9) > (In reply to comment #7) > > (In reply to comment #6) > > > if use -MANIFEST:NO, vc8/9 build crashes. > > > vc10 is no probrem without -MANIFEST:NO. > > > > vc8/9 build shouldn't be using that line. > > sorry, vc8/9 **express** jemalloc build crashes. Ah, I realise my mistake, the crtdll.obj bug doesn't affect debug builds, but release builds have the problem. Please can you file a new bug on vc8/9 express release builds? You'll need to ask khuey to review your patch.

(In reply to comment #11) > (In reply to comment #10) > > (In reply to comment #8) > > > Oops, thanks for spotting this! > > > > thanks. > > this patch solves Bug 674972. > > Pushed changeset f92e021f1f44 to mozilla-central. > thanks. > (In reply to comment #9) > > (In reply to comment #7) > > > (In reply to comment #6) > > > > if use -MANIFEST:NO, vc8/9 build crashes. > > > > vc10 is no probrem without -MANIFEST:NO. > > > > > > vc8/9 build shouldn't be using that line. > > > > sorry, vc8/9 **express** jemalloc build crashes. > > Ah, I realise my mistake, the crtdll.obj bug doesn't affect debug builds, > but release builds have the problem. > > Please can you file a new bug on vc8/9 express release builds? You'll need > to ask khuey to review your patch. ok. I filed a new Bug 675519.

Comment on attachment 547466 [details] [diff] [review] Proposed patch [Checked in: See comment 13] Oh, a modified version of this patch was eventually checked in: http://hg.mozilla.org/mozilla-central/rev/7bc488fc53a3