Closed Bug 674097 Opened 13 years ago Closed 13 years ago

Land TPS in the core

Categories

(Testing Graveyard :: TPS, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Move TPS into the services-central repo. Philip, I propose moving it into /testing/tps; let me know if you think it should go somewhere else.
If the 'testing' module owners are fine with having the TPS harness live there, sure! I think the TPS tests itself should live under services/sync/tests/tps. (P.S.: Thanks for filing... totally forgot about this one ;))
Rephrasing the bug summary slightly to reflect what will happen: Even though we'll probably land this on s-c first, it will eventually make it into m-c because s-c is merged m-c on a weekly basis.
Summary: Move TPS into services-central → Land TPS in the core
Attached patch Move TPS into s-c (deleted) — Splinter Review
This moves TPS into s-c as we discussed; the tests into services/sync/tests/tps, and the harness itself into testing/tps. None of these files are included in a build.
Attachment #548826 - Flags: review?(philipp)
Comment on attachment 548826 [details] [diff] [review] Move TPS into s-c Great! Some nits/questions (don't feel strongly, mostly wondering/pointing out): * I'm not a testing peer, are they going to be ok with us landing TPS there? Maybe split the testing/* and services/sync/tests/tps/* files into two separate commits to have them sign off on the testing/* stuff? * I wonder if the TPS extension for Firefox should also live under services/sync/tps or similar, since it's pretty tightly coupled to Sync (it uses internal APIs). The Python harness should still live in testing of course. * Test files should have the Public Domain header https://www.mozilla.org/MPL/boilerplate-1.1/pd-c
Attachment #548826 - Flags: review?(philipp) → review+
I moved the extension into services/sync/tps, and added headers to all the files that were lacking it. We don't need separate review to land in /testing. http://hg.mozilla.org/services/services-central/rev/5a1e829db409
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Component: General → TPS
QA Contact: general → tps
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: