Closed
Bug 674161
Opened 13 years ago
Closed 13 years ago
Middle mouse paste is not subject to the javascript: URL security changes in bug 656433 (current page's principal shouldn't be inherited)
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 10
People
(Reporter: jruderman, Assigned: Gavin)
References
(Blocks 2 open bugs)
Details
(Keywords: csectype-spoof, sec-low)
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
(Split from bug 405620 -- originally reported by georgi)
1. Select the text
javascript:alert(document.cookie)
2. Middle-click a blank area of another web page
Result: XSS!!1
Combined with bug 405620, this is perhaps a little worse than the other javascript: URL bugs. But it only affects Linux users.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Assignee | ||
Updated•13 years ago
|
Summary: Middle mouse paste is not subject to the javascript: URL security changes in bug 656433 → Middle mouse paste is not subject to the javascript: URL security changes in bug 656433 (current page's principal shouldn't be inherited)
What solution will be made and in what version of FF?
By the way: it also affects addons which loads external content like RSS readers.
In such case evil code will be executed in chrome:// zone.
Assignee | ||
Comment 5•13 years ago
|
||
It would be cleaner to make disallowing the principal inheritance openUILinkIn's default behavior, but that has the potential to break people, given its wide use. Maybe we can revisit that separately.
Attachment #548814 -
Attachment is obsolete: true
Attachment #564925 -
Flags: review?(dao)
Assignee | ||
Comment 6•13 years ago
|
||
This patch is on top of the patch for bug 610203.
Depends on: 610203
Comment 7•13 years ago
|
||
Comment on attachment 564925 [details] [diff] [review]
patch
When you enter a new url in the urlbar in an app tab, it does open in a new tab like we want in bug 598587, but the urlbar value in the app tab doesn't revert like it should.
Additionally, openLinkIn doesn't do a host comparison before deciding to open the url in a new tab, which is part of what bug 598587 requires (however I think this is less of a big deal and could be done in a follow-up bug).
Attachment #564925 -
Flags: feedback-
Assignee | ||
Updated•13 years ago
|
Attachment #564925 -
Flags: review?(dao)
Assignee | ||
Comment 8•13 years ago
|
||
Good catch!
The URL bar changes really aren't relevant to this bug, I shouldn't have included them here. Here's a patch that just fixes this as summarized (which still includes the changes to openLinkIn).
Attachment #567254 -
Flags: review?(dao)
Assignee | ||
Updated•13 years ago
|
Attachment #564925 -
Attachment is obsolete: true
Updated•13 years ago
|
Attachment #567254 -
Flags: review?(dao) → review+
Assignee | ||
Comment 9•13 years ago
|
||
Flags: in-testsuite+
Hardware: x86_64 → All
Target Milestone: --- → Firefox 10
Comment 10•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•11 years ago
|
Keywords: csec-spoof,
sec-low
Whiteboard: [sg:low]
You need to log in
before you can comment on or make changes to this bug.
Description
•