Closed
Bug 674238
Opened 13 years ago
Closed 13 years ago
Simplify favicons INSERT query
Categories
(Firefox :: Bookmarks & History, enhancement)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 8
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
See feature page:
https://wiki.mozilla.org/Services/Sync/FxSync/FaviconSync
Prerequisite for Bug 428378.
Taking this for now. Will holler if I need help.
|
Assignee | |
Comment 1•13 years ago
|
||
Trivial patch. Try builds:
http://tbpl.mozilla.org/?tree=Try&rev=19657de3f84d
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/rnewman@mozilla.com-19657de3f84d.
Places unit tests pass locally, so let's see what try thinks...
Attachment #548614 -
Flags: review?(mak77)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Try looks green.
|
||
Comment 3•13 years ago
|
||
Comment on attachment 548614 [details] [diff] [review]
Part 0: eliminate redundant OR REPLACE from insert query.
Review of attachment 548614 [details] [diff] [review]:
-----------------------------------------------------------------
ah, now I remember why this was here, asyncFaviconHelpers.cpp was using this query before getting its own statementsCache, indeed it's using OR REPLACE atm.
Attachment #548614 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Thanks mak.
Pushed part 0, just to get some more time to bake while I work on the rest:
http://hg.mozilla.org/services/services-central/rev/9d927d1f2ac8
|
||
Updated•13 years ago
|
Whiteboard: [qa-]
|
|
Assignee | |
Comment 5•13 years ago
|
||
Re-casting this bug to reflect the fact that it's landed and the rest will take a while...
Summary: Extend moz_favicons with GUID and lastModified timestamp to support Sync → Simplify favicons INSERT query
Whiteboard: [qa-] → [fixed in services][qa-]
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services][qa-] → [qa-]
Target Milestone: --- → Firefox 8
You need to log in
before you can comment on or make changes to this bug.
Description
•