Closed Bug 674574 Opened 13 years ago Closed 13 years ago

When all components or versions are disabled, you cannot enter bugs into the product but it's listed in enter_bug.cgi anyway

Categories

(Bugzilla :: Administration, task)

4.1.2
task
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.2

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

(Keywords: regression)

Attachments

(1 file)

This is a problem introduced by bug 77193 (Bugzilla 4.2 only): if you have a product with all its components, versions or milestones disabled, you cannot enter bugs into this product (I'm fine with this behavior) but the product is still listed in enter_bug.cgi. The reason is that Bugzilla::User->get_enterable_products() is not aware of this new feature. The SQL query in this method should be updated to take this "enable/disable" bit into account.
Flags: blocking4.2+
Attached patch patch, v1 (deleted) — Splinter Review
No need to check for disabled milestones. If all milestones are disabled, we fall back to the default milestone (even if this milestone is also disabled; but that's another story).
Assignee: administration → LpSolit
Status: NEW → ASSIGNED
Attachment #549664 - Flags: review?(dkl)
Comment on attachment 549664 [details] [diff] [review]
patch, v1

Review of attachment 549664 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works as expected. r=dkl
Attachment #549664 - Flags: review?(dkl) → review+
Flags: approval+
Summary: When all components or versions or milestones are disabled, you cannot enter bugs into the product but it's listed in enter_bug.cgi anyway → When all components or versions are disabled, you cannot enter bugs into the product but it's listed in enter_bug.cgi anyway
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/User.pm
modified template/en/default/global/user-error.html.tmpl
Committed revision 7877.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: