Closed
Bug 674658
Opened 13 years ago
Closed 13 years ago
nsDOMEventTargetWrapperCache fails to unlink inherited fields
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mccr8, Assigned: smaug)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
In content/base/src/nsDOMEventTargetWrapperCache.cpp:
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INHERITED(nsDOMEventTargetWrapperCache,
nsDOMEventTargetHelper)
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_SCRIPT_OBJECTS
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END
NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN(nsDOMEventTargetWrapperCache)
NS_IMPL_CYCLE_COLLECTION_UNLINK_PRESERVED_WRAPPER
NS_IMPL_CYCLE_COLLECTION_UNLINK_END
The Traverse function calls its parent's traverse, but Unlink does not.
This results in 3 fields not being unlinked:
Unrefed fields in nsDOMEventTargetWrapperCache::cycleCollection::Unlink(void*):
(/home/amccreight/tm/content/base/src/nsDOMEventTargetWrapperCache.cpp:61:1)
nsDOMEventTargetHelper::mListenerManager
nsDOMEventTargetHelper::mOwner
nsDOMEventTargetHelper::mScriptContext
Found using my cycle collector static analysis.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → Olli.Pettay
|
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #549179 -
Flags: review?(bent.mozilla)
|
||
Updated•13 years ago
|
Attachment #549179 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•