Closed
Bug 674837
Opened 13 years ago
Closed 13 years ago
Fennec android builds are not thumb anymore
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 8
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: [inbound])
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Since the switch to NDK 5, fennec android builds are not built with -mthumb -march=armv7-a -mfpu=vfp -mfloat-abi=soft-float.
This is because the new target name doesn't match what is checked in configure.in to put these flags.
I think it's time to stop using $target to do these kind of selections, and use our normalized values such as CPU_ARCH and OS_TARGET instead.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #549042 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #549043 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Comment 3•13 years ago
|
||
(In reply to comment #0)
> Since the switch to NDK 5, fennec android builds are not built with -mthumb
> -march=armv7-a -mfpu=vfp -mfloat-abi=soft-float.
This makes the binary significantly bigger, as well as the apk. I'd also expect some talos regression...
|
|
Assignee | |
Comment 4•13 years ago
|
||
with configure
Attachment #549054 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #549043 -
Attachment is obsolete: true
Attachment #549043 -
Flags: review?(ted.mielczarek)
|
||
Comment 5•13 years ago
|
||
Comment on attachment 549042 [details] [diff] [review]
Properly set android build options on NDK5+
Review of attachment 549042 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #549042 -
Flags: review?(ted.mielczarek) → review+
|
|
||
Comment 6•13 years ago
|
||
Comment on attachment 549054 [details] [diff] [review]
Properly set android build options on NDK5+ - nspr part
Review of attachment 549054 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #549054 -
Flags: review?(ted.mielczarek) → review+
|
|
||
Updated•13 years ago
|
Assignee: nobody → mh+mozilla
|
|
Assignee | |
Comment 7•13 years ago
|
||
Attachment #549084 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #549042 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Attachment #549054 -
Attachment is obsolete: true
|
|
||
Updated•13 years ago
|
Attachment #549084 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 8•13 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 10•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
You need to log in
before you can comment on or make changes to this bug.
Description
•