Closed
Bug 675191
Opened 13 years ago
Closed 13 years ago
Cached dynamic overlays still get saved to fastload (startup cache)
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
(Keywords: assertion)
Attachments
(1 file)
(deleted),
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
When loading cached XUL dynamic overlays the document gets saved to the startup cache even though it had been already put in the startup cache when the overlay was originally cached.
Steps to reproduce problem:
1. Open a XUL document that uses dynamic overlays
2. Close and reopen the document
Expected result: Startup cache written once
Actual result: Startup cache written twice
Additional information:
###!!! ASSERTION: Existing entry in StartupCache.: 'entry == nsnull', file startupcache/StartupCache.cpp, line 298
Presumably the old fastload cache didn't do the check.
Assignee | ||
Comment 1•13 years ago
|
||
We should only set mIsFastLoad if we're actually doing a load. We already do this correctly in the two places where we trigger loads (later on in this method and also in StartDocumentLoad). So the code snippet is bogus.
Updated•13 years ago
|
Attachment #549356 -
Flags: review?(enndeakin) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Pushed changeset ed772265d2bc to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•