Closed
Bug 675589
Opened 13 years ago
Closed 13 years ago
Group all session restore menu items together.
Categories
(SeaMonkey :: Bookmarks & History, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ewong, Assigned: ewong)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
This bug was spun off from the comments attributed to bug #599731c11 and
bug #599731c12.
Meaning group all restore session menu items together.
|
Assignee | |
Comment 1•13 years ago
|
||
Ok, further comment. Bug #599731 moved the Recently Closed menu items from
the File menu to the Go Menu. Now basically, the "Restore Previous Session"
should be 'grouped' with these menus.
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → ewong
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•13 years ago
|
||
On the first view, the Go menu has an extra disabled "Tab from other computers" menu item. Subsequent views, that item disappears.
|
||
Comment 3•13 years ago
|
||
Comment on attachment 559084 [details] [diff] [review]
Group all session restore menu items (v1)
>+ endHistory.hidden = (endHistory == aParent.lastChild) || (syncMenuItem.hidden);
Since you didn't ask anyone specifically for review yet, here's a drive-by: Technically, no parentheses is needed here at all. Personally I'd go with one (for everything on the right side), but the reviewer you choose might disagree.
|
|
Assignee | |
Comment 4•13 years ago
|
||
Attachment #559084 -
Attachment is obsolete: true
Attachment #582743 -
Flags: review?(iann_bugzilla)
Attachment #582743 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/b9f97ed7e628
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•