Closed
Bug 675711
Opened 13 years ago
Closed 13 years ago
test_computed_style.html fails partly on Fennec because of lack of scrollbars
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: martijn.martijn, Assigned: martijn.martijn)
References
Details
(Whiteboard: [inbound])
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
Firefox has scrollbars and this test assumes scrollbars, which makes the border-radius much smaller (the border width). But Fennec doesn't have scrollbars, so the border-radius isn't clamped at all for overflow:scroll frames. Hence the failing tests there.
The attached patch corrects it.
Attachment #549891 -
Flags: review?(jmaher)
|
||
Comment 1•13 years ago
|
||
Where does the " - 10" come from? Is that the width of a scrollbar for you? If so, shouldn't the test be == 0, and for the other branch (or just ==, without -)?
Also, the text probably shouldn't say "clamped" when there's actually no clamping.
|
|
||
Updated•13 years ago
|
Component: Mochitest → Style System (CSS)
Product: Testing → Core
QA Contact: mochitest → style-system
|
|
||
Updated•13 years ago
|
Component: Style System (CSS) → Layout
QA Contact: style-system → layout
|
Assignee | |
Comment 2•13 years ago
|
||
The 10 comes from the border-width (5px on both sides), which is not included in the clientWidth value.
Attachment #549897 -
Flags: review?(dbaron)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 549897 [details] [diff] [review]
patch
r=dbaron
Attachment #549897 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•13 years ago
|
||
One change from the previous patch:
Instead of:
if (p.clientWidth == p.offsetWidth - 10) {
I now use this:
if (p.clientHeight == p.offsetHeight - 10) {
for overflow-X scroll divs.
Stupid mistake. Instead of only testing this mochitest on Fennec, I should have tested on Firefox too, of course.
Attachment #549891 -
Attachment is obsolete: true
Attachment #549897 -
Attachment is obsolete: true
Attachment #549891 -
Flags: review?(jmaher)
Attachment #549902 -
Flags: review?(dbaron)
|
|
||
Updated•13 years ago
|
Attachment #549902 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Updated•13 years ago
|
Assignee: nobody → martijn.martijn
|
||
Comment 5•13 years ago
|
||
all green on try server, pushed to mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/fbf02dd1803e
Keywords: checkin-needed
Whiteboard: [inbound]
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•