User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/534.30 (KHTML, like Gecko) Chrome/12.0.742.122 Safari/534.30 Expected results: When a block element is set to display:inline, it is desirable for it to behave bidi-wise as it would if it were display:inline-block. Under CSS2.1, there was no way to accomplish this, and unicode-bidi:embed was used for lack of a better choice. Now that we have unicode-bidi:isolate, it should be the default instead, as the HTML5 spec (http://dev.w3.org/html5/spec/Overview.html#non-replaced-elements) says it should be.

This is included in the patch for bug 613149 at https://bugzilla.mozilla.org/attachment.cgi?id=525116&action=diff#a/layout/style/html.css_sec2

The testcase is NOT fixed by bug 613149 -- I'll look into it.

The change needs to be effective for "block" elements whether or not they have a dir attribute. The change already made in the stylesheet is not sufficient because the generic [dir] {unicode-bidi:embed;} is considered more specific and overrides it for "block" elements with a dir attribute. See http://www.w3.org/Bugs/Public/show_bug.cgi?id=14850.

(In reply to Aharon (Vladimir) Lanin from comment #3) > The change needs to be effective for "block" elements whether or not they > have a dir attribute. The change already made in the stylesheet is not > sufficient because the generic [dir] {unicode-bidi:embed;} is considered > more specific and overrides it for "block" elements with a dir attribute. > See http://www.w3.org/Bugs/Public/show_bug.cgi?id=14850. Great catch! In spite of discussing this exact issue with Aharon a few days ago, the penny didn't drop for me that it was the cause of this bug. The patch also adds unicode-bidi: -moz-isolate for a few elements from http://dev.w3.org/html5/spec/Overview.html#flow-content-1, http://dev.w3.org/html5/spec/Overview.html#sections-and-headings, http://dev.w3.org/html5/spec/Overview.html#lists, and http://dev.w3.org/html5/spec/Overview.html#tables which didn't have it before: <figcaption>, <figure>, <legend>, and <summary>,

I found a bug in the patch through rniwa's tests in bug 706194: the rule for pre[dir] was overriding the rule for pre[dir="auto"] earlier in the file.

*sigh*

Comment on attachment 577911 [details] [diff] [review] Patch v.2b r=dbaron, but perhaps update the spec quote to cite HTML5?

Comment on attachment 575192 [details] [diff] [review] Attachment 550374 [details] as reftest, updated r=dbaron

https://hg.mozilla.org/integration/mozilla-inbound/rev/e45974ac5499 https://hg.mozilla.org/integration/mozilla-inbound/rev/59844258e406

https://hg.mozilla.org/mozilla-central/rev/e45974ac5499 https://hg.mozilla.org/mozilla-central/rev/59844258e406