see the patch in bug 660206 and https://bugzilla.mozilla.org/show_bug.cgi?id=660206#c20 for an approach to fix this, practically right now creating a nsIconChannel in xpcshell on Linux fails badly, thus changing components to deal with icon channels causes xpcshell failures, we should avoid at least that. Scope of this bug is to take the icon channel part of the patch in that bug, add the missing part suggested by karlt in the comment, and write a small xpcshell test that creates a nsIconChannel, to check it doesn't fail/crash badly.

This patch was submitted to tryserver and passed all xpcshell tests on Linux: http://tbpl.mozilla.org/?tree=Try&rev=63610d480335

Comment on attachment 552293 [details] [diff] [review] Patch for bug 676736 Review of attachment 552293 [details] [diff] [review]: ----------------------------------------------------------------- You should merge here the changes in the patch in bug 660206 (esp now that it has been wontfixed), excluded the changes to nsIFaviconService.idl. That way we invoke g_type_init before this one, Karlt pointed out gdk3 will require that. Does this actually fixes the original issue we had with tests in bug 564916? did you try to push them together and see if the problem is gone? ::: toolkit/components/places/tests/unit/test_moz-icon_throws_on_linux.js @@ +1,5 @@ > +/* vim:set ts=2 sw=2 sts=2 et: */ > +/* ***** BEGIN LICENSE BLOCK ***** > + * Any copyright is dedicated to the Public Domain. > + * http://creativecommons.org/publicdomain/zero/1.0/ > + * ***** END LICENSE BLOCK ***** */ the right license block is this one http://www.mozilla.org/MPL/boilerplate-1.1/pd-c ::: toolkit/components/places/tests/unit/xpcshell.ini @@ +71,5 @@ > [test_livemarkService_getLivemarkIdForFeedURI.js] > [test_markpageas.js] > [test_moz-anno_favicon_mime_type.js] > +[test_moz-icon_throws_on_linux.js] > +run-if = os == 'linux' While the test may be fine for our specific needs, it should rather be a libpr0n test (modules\libpr0n\test\unit) and not depend on Places, it should manually create a channel to an icon (something like Services.io.newChannelFromURI may be enough, modules/libpr0n/test/unit/async_load_tests.js does something similar).

Unassigning as I haven't been working on this and don't think I will have time to pick it back up.