Closed Bug 676793 Opened 13 years ago Closed 13 years ago

Failure in cloning the mozmill-tests repository with Mercurial 1.9 due to injection of peeropts parameter

Categories

(Mozilla QA Graveyard :: Mozmill Automation, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ilya.nesterov, Assigned: whimboo)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux i686) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/13.0.782.107 Safari/535.1 Steps to reproduce: I am trying to run testrun_functional.py but it cause an exception during cloning repository. Actual results: ./testrun_functional.py --repository="/home/ilya/work/mozmilTesting/mozmill-tests/" firefox/ *** Cloning repository to '/tmp/tmp8ji_b3.mozmill-tests' Traceback (most recent call last): File "./testrun_functional.py", line 84, in <module> main() File "./testrun_functional.py", line 81, in main run.run() File "/home/ilya/work/mozmilTesting/mozmill-automation/libs/testrun.py", line 285, in run self.clone_repository() File "/home/ilya/work/mozmilTesting/mozmill-automation/libs/testrun.py", line 179, in clone_repository e.message) Exception: Failure in setting up the mozmill-tests repository. 'str' object has no attribute 'get' here is my environment details: Linux 2.6.39-pae #1 SMP PREEMPT Tue Jul 26 12:53:04 NOVST 2011 i686 Intel(R) Core(TM)2 Quad CPU Q9400 @ 2.66GHz GenuineIntel GNU/Linux Mercurial Distributed SCM (version 1.9)
The reason for this failure is the newly introduced peeropts parameter of hg.clone(): http://hg.kublai.com/mercurial/main/file/f4522df38c65/mercurial/hg.py#l177 http://hg.kublai.com/mercurial/main/rev/d976542986d2 Lets see how we can solve this as best.
Assignee: nobody → hskupin
Blocks: 671724
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Summary: "Exception: Failure in setting up the mozmill-tests repository" using Mercurial 1.9 → Failure in cloning the mozmill-tests repository with Mercurial 1.9 due to injection of peeropts parameter
Attached patch Patch v1 (deleted) — Splinter Review
Not sure if that is the best approach but due to the API breakage in Mercurial 1.9 I have to differentiate for now between versions >=1.9 and <1.9. Jeff, if you have a better approach in mind, I would kinda like to hear your opinion.
Attachment #551022 - Flags: review?(jhammel)
Comment on attachment 551022 [details] [diff] [review] Patch v1 This should work for now
Attachment #551022 - Flags: review?(jhammel) → review+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
I can confirm that it is fixed now.
Thanks Ilya!
Status: RESOLVED → VERIFIED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: