Closed
Bug 677329
Opened 13 years ago
Closed 12 years ago
Implement WebIDL array types
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: ted, Unassigned)
References
()
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
These would be useful. I'd like to use them. Once we kill off the C implementation of xpidl this won't be too hard.
Reporter | ||
Comment 1•13 years ago
|
||
This patch adds the necessary parsing changes to xpidl.py to handle WebIDL array types. I also added a small test suite for the parser. It's nowhere near comprehensive, but it tests around the areas I was changing, so it made me feel better.
This isn't actually useful yet, as it needs to be hooked up to header.py and the patch that hasn't been finished yet for bug 458936. We'll want to handle Array types by synthesizing an additional length parameter, presumably. (Unless we want to go crazy and make xptcall handle nsTArray or something neat like that.)
Reporter | ||
Comment 2•13 years ago
|
||
I split the tests off into their own patch.
Reporter | ||
Comment 3•13 years ago
|
||
On top of the patch from the other bug. We might not actually want to take this. khuey and I have been talking, and we may fork the xpidl.py parser to make a webidl.py parser, so as not to intermingle all the legacy xpidl crap in with WebIDL.
Reporter | ||
Updated•13 years ago
|
Attachment #551530 -
Attachment is obsolete: true
Comment 4•13 years ago
|
||
(In reply to Ted Mielczarek [:ted, :luser] from comment #3)
> Created attachment 551877 [details] [diff] [review]
> Support WebIDL array types in xpidl.py parser
>
> On top of the patch from the other bug. We might not actually want to take
> this. khuey and I have been talking, and we may fork the xpidl.py parser to
> make a webidl.py parser, so as not to intermingle all the legacy xpidl crap
> in with WebIDL.
That sounds like a decent idea.
Reporter | ||
Updated•13 years ago
|
Assignee: ted.mielczarek → nobody
Comment 5•13 years ago
|
||
Is there a timeline for the WebIDL parser?
No.
Reporter | ||
Comment 7•12 years ago
|
||
We totally have a separate WebIDL parser now, so use that.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
No longer blocks: 768048
You need to log in
before you can comment on or make changes to this bug.
Description
•