Closed
Bug 677859
Opened 13 years ago
Closed 13 years ago
Stop using abDirTreeOverlay
Categories
(SeaMonkey :: MailNews: Address Book & Contacts, defect)
SeaMonkey
MailNews: Address Book & Contacts
Tracking
(seamonkey2.6 fixed)
RESOLVED
FIXED
seamonkey2.6
Tracking | Status | |
---|---|---|
seamonkey2.6 | --- | fixed |
People
(Reporter: neil, Assigned: iannbugzilla)
References
Details
Attachments
(1 file)
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
abDirTreeOverlay still contains some RDF cruft. We should merge the bits we need (some of the attributes, the column header, and the treechildren element) into addressbook and then remove all references to it. Then we can file a bug on Thunderbird to completely remove it from the codebase.
This patch:
* Removes references to abDirTreeOverlay.xul from all suite files.
* Folds in relevant parts of abDirTreeOverlay.xul into suite's addressbook.xul
* Adds relevant entity to abMainWindow.dtd
* Removes locale file abDirTreeOverlay.dtd and suite references to it.
Reporter | ||
Comment 2•13 years ago
|
||
Comment on attachment 558670 [details] [diff] [review]
Fold in abDirTreeOverlay [Checked in: Comment 3]
>+ <tree id="dirTree"
>+ class="abDirectory plain"
>+ seltype="single"
>+ style="min-width:150px"
>+ flex="1"
>+ persist="width"
>+ hidecolumnpicker="true"
>+ context="dirTreeContext"
>+ onselect="DirPaneSelectionChange(); document.commandDispatcher.updateCommands('addrbook-select');"
>+ ondblclick="DirPaneDoubleClick(event);"
>+ onclick="DirPaneClick(event);"
>+ onblur="goOnEvent(this,'blur');">
Nit: could clean up the formatting (space after : and ,)
>+ ignoreincolumnpicker="true"/>
Probably don't need that if we're hiding the columnpicker ;-)
Attachment #558670 -
Flags: review?(neil) → review+
Comment on attachment 558670 [details] [diff] [review]
Fold in abDirTreeOverlay [Checked in: Comment 3]
With changes as suggested:
http://hg.mozilla.org/comm-central/rev/481444f2b269
Attachment #558670 -
Attachment description: Fold in abDirTreeOverlay → Fold in abDirTreeOverlay [Checked in: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
status-seamonkey2.6:
--- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.6
You need to log in
before you can comment on or make changes to this bug.
Description
•