To continue the work being done in bug 672225, we should look toward removing PRBools in nsRefreshDriver.h/.cpp, as well as in nsImageFrame.h/.cpp, and replace these occurrences with simple bools.

In nsRefreshDriver.(h|cpp) and nsImageFrame.(h|cpp): s/PRBool/bool/g s/PR_FALSE/false/g s/PR_TRUE/true/g Minus the following instances that would require multiple changes elsewhere in the tree (if my MXR foo is correct): layout/generic/nsImageFrame.h - virtual PRBool IsFrameOfType(PRUint32 aFlags) const + virtual bool IsFrameOfType(PRUint32 aFlags) const layout/generic/nsImageFrame.cpp NS_IMETHODIMP nsImageFrame::IconLoad::OnDataAvailable(imgIRequest *aRequest, - PRBool aCurrentFrame, + bool aCurrentFrame, NS_IMETHODIMP nsImageFrame::IconLoad::OnStopRequest(imgIRequest *aRequest, - PRBool aIsLastPart) + bool aIsLastPart) layout/base/nsRefreshDriver.cpp -static PRBool sPrecisePref; +static bool sPrecisePref; /* static */ void nsRefreshDriver::InitializeStatics() { Preferences::AddBoolVarCache(&sPrecisePref, "layout.frame_rate.precise", - PR_FALSE); + false);

Comment on attachment 554194 [details] [diff] [review] Patch v1 Review of attachment 554194 [details] [diff] [review]: ----------------------------------------------------------------- This is OK, but please don't do any more of these. Michael Wu is working on wholesale, automated PRBool -> bool conversion so it's not really worth anyone's time to do it bit by bit.

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #2) > This is OK, but please don't do any more of these. Michael Wu is working on > wholesale, automated PRBool -> bool conversion so it's not really worth > anyone's time to do it bit by bit. Ah indeed in bug 675553. That plus the fact that the patch attached here causes M3, M5 and crashtest failures as is (http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=1f298a2b3b2c) - makes me think it's easier to just dupe this to there and wait on the automated solution; rather than trying to continue any more here.