Closed
Bug 678166
Opened 13 years ago
Closed 13 years ago
Use the original CID for the mock object in mockObjects.js
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: mounir, Assigned: mounir)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Trying to find what was happening with the test in bug 463491, I realized mockObjects.js was creating a new CID but Components.classes[contractId] was still pointing to the original CID making Components.classes[contractId].createInstance() to fail if the previous factory was removed.
For unknown reasons, in the current state of the file, it will work but the original factory isn't removed. The test in bug 463491 was failing because .unregisterFactory() was called and it seems that as soon as it's done, you can't use mockObjects.js for the same factory. IOW, launching two times in a row the same test was always failing. The same way, unregistering the original factory before registering the new one was making the test to always fail.
It goes without saying: this patch went to try and the tree is green.
Attachment #552348 -
Flags: review?(ehsan)
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs review]
|
||
Updated•13 years ago
|
Attachment #552348 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 1•13 years ago
|
||
Thank you for the quick review!
Flags: in-testsuite+
Whiteboard: [needs review] → [inbound]
|
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•