Closed
Bug 678244
Opened 13 years ago
Closed 13 years ago
Fix minor coding errors in patch from bug 602718
Categories
(Thunderbird :: Message Reader UI, defect)
Thunderbird
Message Reader UI
Tracking
(thunderbird8 fixed)
RESOLVED
FIXED
Thunderbird 9.0
| Tracking | Status | |
|---|---|---|
| thunderbird8 | --- | fixed |
People
(Reporter: jik, Assigned: jik)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
Bienvenu
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
The Seamonkey folks over in bug 677905 found two bugs in my recent changes which were checked in in bug 602718. My code calls document.getElementById on a potentially null value, and in one location where I copied and modified some code I forgot to change AllowHTML_menuitem to AllBodyParts_menuitem. D'oh! The attached patch fixes both issues.
|
Assignee | |
Updated•13 years ago
|
|
|
Assignee | |
Updated•13 years ago
|
Attachment #552436 -
Flags: review?(dbienvenu)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 552436 [details] [diff] [review]
patch to fix both minor coding issues
looks good, thx.
Attachment #552436 -
Flags: review?(dbienvenu) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 552436 [details] [diff] [review]
patch to fix both minor coding issues
I think this needs to go into the Aurora branch as well or it'll be broken in TB8 when it's released. I think I set approval-comm-aurora? to request that? Is that right?
Attachment #552436 -
Flags: approval-comm-aurora?
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
Yes, now that 8.0 migrated to the aurora channel it needs to land there as well.
Your requests are fine as set, someone should take care of both from here.
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
|
|
||
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Updated•13 years ago
|
Attachment #552436 -
Flags: approval-comm-aurora? → approval-comm-aurora+
|
|
||
Comment 5•13 years ago
|
||
|
|
||
Updated•13 years ago
|
status-thunderbird8:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•