User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20100101 Firefox/5.0 Build ID: 20110622232440 Steps to reproduce: cppcheck 1.49 (http://cppcheck.sourceforge.net/) found a plenty of potential null pointer dereference. This is one of them. Actual results: in the line #53 there is a check for 'aSurface' is null or not, but at line #65 there is an unchecked aSurface-> which is a potential null pointer dereference. Expected results: Well, it depends. I do not know the code well enough, but you definitely should check the pointer before dereference. A possible fix is attached, but this fix seems ugly for me. (But I have no better idea.)

Realistically, aSurface should never be NULL there, and if it is, we've got bigger problems! The right solution is probably to remove the NULL check at the top, and add a 'if (!aSurface) { return NULL; }' to the top of that function. I doubt that wouldn't break further down the flow though.

Unassigning from David per his request (bug 679610 comment 4). For anyone looking at this bug, feel free to take it, David has very kindly provided a patch, but will not have time to follow it through.

Comment on attachment 589659 [details] [diff] [review] fix per comment 1 Review of attachment 589659 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/d3d10/ImageLayerD3D10.cpp @@ +49,5 @@ > SurfaceToTexture(ID3D10Device *aDevice, > gfxASurface *aSurface, > const gfxIntSize &aSize) > { > + if (!aSurface) { return NULL; } nit: as per coding style if (!aSurface) { return NULL; }

Carrying over review=bas.schouten .