Closed
Bug 679708
Opened 13 years ago
Closed 13 years ago
Further Lion-ize Toolbar Icons
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 9
People
(Reporter: shorlander, Assigned: shorlander)
References
Details
(Keywords: addon-compat)
Attachments
(3 files, 3 obsolete files)
To further Lion-ize the toolbar icons:
* Update style: lighter gradient and stronger inner shadow
* Update Library icons and tabstrip icons
* Disabled icons should be 60% opacity
* Inactive window:
- Icons should be 60% opacity
- Disabled icons should be 30% opacity
- Have a hover 100% opacity hover state
The attached WIP patch updates the images but I am not sure if there is a way to make Lion specific CSS rules for the inactive window state?
Attachment #553769 -
Flags: feedback?(mstange)
Assignee | ||
Comment 1•13 years ago
|
||
Comment 2•13 years ago
|
||
Comment on attachment 553769 [details] [diff] [review]
Update Lion Glyphs - 01 WIP
Looks great!
(In reply to Stephen Horlander from comment #0)
> The attached WIP patch updates the images but I am not sure if there is a
> way to make Lion specific CSS rules for the inactive window state?
Not yet. I'll write a patch that adds :-moz-system-metric(mac-lion-theme).
Attachment #553769 -
Flags: feedback?(mstange) → feedback+
Comment 3•13 years ago
|
||
Also, have you piped the images through an optimizer like ImageOptim?
Assignee | ||
Comment 4•13 years ago
|
||
Design for normal, disabled and inactive states
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to Markus Stange from comment #3)
> Also, have you piped the images through an optimizer like ImageOptim?
Yes, I used ImageOptim.
> Not yet. I'll write a patch that adds :-moz-system-metric(mac-lion-theme).
Awesome, thank you!
Assignee | ||
Comment 6•13 years ago
|
||
Updated patch using -moz-mac-lion-theme for disabled and inactive-window rules. Also removed bookmarks and history checked hover:active state since it isn't used anymore
Attachment #553769 -
Attachment is obsolete: true
Attachment #554437 -
Flags: feedback?(mstange)
Assignee | ||
Comment 7•13 years ago
|
||
Attachment #553772 -
Attachment is obsolete: true
Updated•13 years ago
|
Attachment #554437 -
Flags: feedback?(mstange) → feedback+
Assignee | ||
Updated•13 years ago
|
Attachment #554437 -
Flags: review?(dao)
Comment 8•13 years ago
|
||
Comment on attachment 554438 [details]
Patch Screenshot - 02
The disabled state seems quite subtle (significantly more subtle than on Windows until recently, where people already complained). I guess I can only blame Apple for this?
Assignee | ||
Comment 9•13 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #8)
> Comment on attachment 554438 [details]
> Patch Screenshot - 02
>
> The disabled state seems quite subtle (significantly more subtle than on
> Windows until recently, where people already complained). I guess I can only
> blame Apple for this?
It is pretty subtle. The push towards less contrasty icons in Lion makes the available range for disabled more narrow.
We don't have to conform exactly however I don't think it will be confusing in the context of Lion. It is more obvious in use than in a screenshot.
Pushing the opacity down to .5 would make it more obvious and probably wouldn't look out of place.
Comment 10•13 years ago
|
||
Comment on attachment 554437 [details] [diff] [review]
Update Lion Glyphs - 02
Ok, I think we should use 50% opacity for the disabled state, or really any other value that gets us closer to 40% without alienating die-hard OS X enthusiasts.
Attachment #554437 -
Flags: review?(dao) → review+
Assignee | ||
Comment 11•13 years ago
|
||
I changed the opacity to .5 here which is a small but noticeable improvement.
Attachment #554438 -
Attachment is obsolete: true
Comment 12•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9
Updated•13 years ago
|
Assignee: nobody → shorlander
Comment 14•13 years ago
|
||
(In reply to Nils Maier [:nmaier] from comment #13)
> Manifest overrides may break third party themes
I wasn't aware of this. Please file a bug?
Comment 15•13 years ago
|
||
See bug 702558.
You need to log in
before you can comment on or make changes to this bug.
Description
•