Closed
Bug 680201
Opened 13 years ago
Closed 11 years ago
test_webcal.js fails due to redefinition of Cc
Categories
(Calendar :: Build Config, defect, P1)
Calendar
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
3.2
People
(Reporter: standard8, Assigned: Fallen)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
redDragon
:
review+
|
Details | Diff | Splinter Review |
Having just enabled unit tests on Calendar, on the Linux 64 box we're seeing:
TEST-UNEXPECTED-FAIL | /buildbot/comm-central-lightning-linux64/build/objdir-tb/mozilla/_tests/xpcshell/calendar/test/unit/test_webcal.js | test failed (with xpcshell return code: 3), see following log:
>>>>>>>
/buildbot/comm-central-lightning-linux64/build/objdir-tb/mozilla/dist/bin/components/httpd.js:51: TypeError: redeclaration of const Cc
<<<<<<<
I'm therefore disabling the test for now so that the builds will be green still.
Reporter | ||
Comment 1•13 years ago
|
||
Checked in the patch to disable the test: http://hg.mozilla.org/comm-central/rev/1f48f873106e
Depends on: 405007
Assignee | ||
Comment 2•11 years ago
|
||
httpd.js has evolved quite a bit, its time to freshen up this test. Unfortunately we cannot test webcals:// yet due to bug 466524.
Assignee | ||
Updated•11 years ago
|
Priority: -- → P1
Comment 3•11 years ago
|
||
Comment on attachment 8383778 [details] [diff] [review]
Fix - v1
Review of attachment 8383778 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM. Tested all the unit tests including this one. Passes. I must say running all the tests takes longer than building the source :) Also the patch does not have a commit message. Setting + for review.
Attachment #8383778 -
Flags: review?(mohit.kanwal) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Pushed to comm-central changeset e29d9bda46d3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.2
You need to log in
before you can comment on or make changes to this bug.
Description
•