Closed
Bug 680427
Opened 13 years ago
Closed 13 years ago
Fix MozMill MsgHdrToMimeMessage callers
Categories
(Thunderbird :: Testing Infrastructure, defect)
Thunderbird
Testing Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 9.0
People
(Reporter: rain1, Assigned: rain1)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
asuth
:
review+
protz
:
feedback+
|
Details | Diff | Splinter Review |
Our MozMill MsgHdrToMimeMessage callers are currently a little broken.
- The callbacks should be wrapped so that the exception they throw on failure isn't just eaten up.
- The callback is the *third* argument, not the second.
Attachment #554405 -
Flags: review?(bugmail)
Attachment #554405 -
Flags: feedback?(jonathan.protzenko)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 554405 [details] [diff] [review]
patch v1
The frame.events.fail is very nice. Since a regular exception ends up eaten by XPConnect, I'm glad you found a way to make that failure obvious in the test logs. Do you think we could do the same for xpcshell tests?
Attachment #554405 -
Flags: feedback?(jonathan.protzenko) → feedback+
|
||
Comment 2•13 years ago
|
||
Comment on attachment 554405 [details] [diff] [review]
patch v1
vontastic. Let's use a separate bug if we make the xpcshell tests fancy too.
Attachment #554405 -
Flags: review?(bugmail) → review+
|
Assignee | |
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
You need to log in
before you can comment on or make changes to this bug.
Description
•