Closed Bug 680511 Opened 13 years ago Closed 13 years ago

Consolidate checkspelling key into editorOverlay.xul

Categories

(SeaMonkey :: Composer, defect)

defect
Not set
normal

Tracking

(seamonkey2.6 fixed)

RESOLVED FIXED
seamonkey2.6
Tracking Status
seamonkey2.6 --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

Attachments

(1 file)

There is a key for checkspelling in both editorOverlay.xul and messengercompose.xul, they could be consolidated into a single one in editorOverlay.xul This patch: * Removes key_checkspelling from messengercompose.xul and its associated entity from messengercompose.dtd * Renames checkspellingkb to key_checkspelling and associated references in editorOverlay.xul * Removes unneeded disabled attribute from key, menuitem and toolbarbutton in editorOverlay.xul * Removes JS code for enablement of above xul in editor.js as already done in isCommandEnabled code.
Attachment #554489 - Flags: review?(neil)
Comment on attachment 554489 [details] [diff] [review] De-dupe checkspelling key [Checked in: Comment 2] > HideItem("spellingButton"); > HideItem("menu_checkspelling"); > RemoveItem("sep_checkspelling"); I guess there was no point disabling them if they'll get hidden anyway ;-)
Attachment #554489 - Flags: review?(neil) → review+
Attachment #554489 - Attachment description: De-dupe checkspelling key → De-dupe checkspelling key [Checked in: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.6
Depends on: 716481
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: