Closed
Bug 680550
Opened 13 years ago
Closed 13 years ago
Handle removeAllPages more sanely in tests
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: mak, Assigned: mak)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
Tests should ensure cleanup is done before proceeding.
I've run all tests locally, but I will push to try before landing.
Attachment #554554 -
Flags: review?(dietrich)
|
Assignee | |
Comment 1•13 years ago
|
||
forgot a qref
Assignee: nobody → mak77
Attachment #554554 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #554554 -
Flags: review?(dietrich)
Attachment #554555 -
Flags: review?(dietrich)
|
||
Comment 2•13 years ago
|
||
Try run for 0897fbc69a57 is complete.
Detailed breakdown of the results available here:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=0897fbc69a57
Results (out of 101 total builds):
success: 91
warnings: 8
failure: 2
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mak77@bonardo.net-0897fbc69a57
|
|
Assignee | |
Comment 3•13 years ago
|
||
the failures are unrelated, just a nice collection of random orange (unfortunately) :(
|
||
Comment 4•13 years ago
|
||
Comment on attachment 554555 [details] [diff] [review]
patch v1.1
Review of attachment 554555 [details] [diff] [review]:
-----------------------------------------------------------------
r=me.
Attachment #554555 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•