Closed
Bug 680848
Opened 13 years ago
Closed 7 years ago
Add MKSHLIB_FORCE_ALL/MKSHLIB_UNFORCE_ALL flags when linking static libraries
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: glandium, Unassigned)
References
Details
Attachments
(1 file)
The new fakelibs support removed the use of the MKSHLIB_FORCE_ALL/MKSHLIB_UNFORCE_ALL flags, but there are some cases where we do pass the .a file to the linker, in which case the behaviour is not the same as passing the individual .o files. Wrapping the remaining .a files on the command line with MKSHLIB_FORCE_ALL/MKSHLIB_UNFORCE_ALL would solve this.
While this is not strictly necessary, it makes things easier for bug 680440.
Incidentally, doing so would fix builds with NO_EXPAND_LIBS=1, which currently fail linking libxul.so because of the lack of MKSHLIB_FORCE_ALL/MKSHLIB_UNFORCE_ALL.
|
Reporter | |
Comment 1•13 years ago
|
||
Attachment #554802 -
Flags: review?(ted.mielczarek)
|
|
Reporter | |
Updated•13 years ago
|
Assignee: nobody → mh+mozilla
|
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 554802 [details] [diff] [review]
Add MKSHLIB_FORCE_ALL/MKSHLIB_UNFORCE_ALL flags when linking static libraries
This breaks tracemalloc builds.
Attachment #554802 -
Flags: review?(ted.mielczarek)
|
|
Reporter | |
Comment 3•7 years ago
|
||
MKSHLIB_FORCE_ALL/MKSHLIB_UNFORCE_ALL were removed in bug 1188555.
Assignee: mh+mozilla → nobody
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•