Closed
Bug 68174
Opened 24 years ago
Closed 5 years ago
Remove event handlers from within <template> (mail/ and mailnews/ part)
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: sspitzer, Assigned: sgautherie)
References
(Blocks 3 open bugs)
Details
(Keywords: perf, Whiteboard: [SergeG> Don't R.Fixed this bug; I'll do it...])
Attachments
(8 files, 5 obsolete files)
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
neil
:
review-
|
Details | Diff | Splinter Review |
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
see #68074 for background. I've found 5 files (in the *.xul under mozilla/mailnews, we should check ns) for xul where we used templates and have event handlers on generated content. mailWindowOverlay.xul oncommand="MsgMoveMessage(event.target)" oncommand="MsgCopyMessage(event.target)" oncommand="MsgGetMessagesForAccount(event)" msgFolderPickerOverlay.xul oncommand="PickedMsgFolder(event.target,'msgNewFolderPicker')" etc. (there are a whole crap load like that) FilterListDialog.xul onclick="onToggleEnabled(event);" pref-composing_messages.xul oncreate="dump('CREATE MENU NOW\n');" messengercompose.xul oncommand="MessageFcc(event.target)" I'm most interested in messengecompose.xul and mailwindowOverlay.xul, since they are going to be hit on startup of message compose and the 3 pane. racham / ducarroz, I'll probably need your help fix this.
Reporter | ||
Comment 3•24 years ago
|
||
the easy one, pref-composing_messages.xul, has been fixed on the mail performance branch.
Reporter | ||
Comment 4•24 years ago
|
||
strike that, I accidentally landed that on the trunk, but brendan let it slide.
Reporter | ||
Comment 5•24 years ago
|
||
adding gayatrib. I think she's got some of these changes in her local tree for search.
Comment 6•23 years ago
|
||
This looks like low hanging fruit for startup perf... nom nsbeta1.
Keywords: nsbeta1
Comment 7•23 years ago
|
||
Indeed, this could speed us up and would be pretty easy to fix I think.
Keywords: perf
Reporter | ||
Comment 8•23 years ago
|
||
when prioritizing this among your other bugs, you should see just how much of a win it would be. one way to estimate this is to take out event handlers and see if you get any performance increase.
Comment 9•23 years ago
|
||
moving to 0.9.2 for the moment. If someone can update this bug with whether or not it makes much of a difference, that would be appreciated.
Priority: -- → P2
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.2
Comment 13•23 years ago
|
||
moving to 0.9.6
Comment 15•23 years ago
|
||
moving to 1.0. If someone believes this will make a noticeable difference then we can move it in.
Target Milestone: mozilla0.9.6 → mozilla1.0
Updated•23 years ago
|
Comment 16•23 years ago
|
||
Moving the event handlers should be a straightforward exercise. Should they go on the outermost menupopup or on the menupopup parent?
Comment 18•20 years ago
|
||
status?
Updated•20 years ago
|
Product: Browser → Seamonkey
Updated•19 years ago
|
Assignee: sspitzer → mail
Assignee | ||
Updated•17 years ago
|
Priority: P2 → --
QA Contact: esther
Hardware: PC → All
Target Milestone: Future → ---
Assignee | ||
Updated•17 years ago
|
Component: MailNews: Main Mail Window → MailNews: Backend
Product: Mozilla Application Suite → Core
Assignee | ||
Updated•17 years ago
|
Assignee: mail → nobody
QA Contact: backend
Assignee | ||
Comment 19•17 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008011403 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) Both cases work. But I guess there would be a better test to use !? ***** Could someone post an up-to-date list of which files/cases need to be fixed ? (It seems searching for "oncommand" between "<template>.*</template>" is not possible with (LXR/)MXR.)
Comment 20•17 years ago
|
||
Comment on attachment 297072 [details] [diff] [review] (Av1-SM) <messengercompose.xul> >+ oncommand="MessageFcc((event.target.getAttribute('id') === '') ? event.target.parentNode.parentNode : event.target);"> Sorry, I don't like this. I can think of two alternatives: 1. Change MessageFcc to find the right id 2. Add another attribute, e.g. fcc="rdf:*", and use that instead
Attachment #297072 -
Flags: review?(neil) → review-
Assignee | ||
Comment 21•17 years ago
|
||
(In reply to comment #20) > (From update of attachment 297072 [details] [diff] [review]) > >+ oncommand="MessageFcc((event.target.getAttribute('id') === '') ? event.target.parentNode.parentNode : event.target);"> > Sorry, I don't like this. I can think of two alternatives: Me, neither: this was only how far I could go/show. > 1. Change MessageFcc to find the right id If you mean moving the test inside the function, this, I can do, but I'm not sure I like it. Yet, if you feel that it's a good solution, fine with me. > 2. Add another attribute, e.g. fcc="rdf:*", and use that instead That's more what I would like ... if it's no bad wrt perf/footprint. (I read doc. and tried a little, but didn't succeed.) But, for this, I would need a full example (with this file), which I could use for the other files as needed: helpwanted ! Thanks.
Assignee | ||
Updated•17 years ago
|
Keywords: helpwanted
Comment 22•17 years ago
|
||
(In reply to comment #21) >I would need a full example (with this file) I'm sure you can work it out from these hints: <menupopup> - <menuitem label="&fileHereMenu.label;" - oncommand="MessageFcc(event.target.parentNode.parentNode)"/> + <menuitem label="&fileHereMenu.label;" resource="rdf:*"/> <menuseparator/> <menuitem uri="..." class="folderMenuItem menuitem-iconic" la bel="rdf:http://home.netscape.com/NC-rdf#Name" - oncommand="MessageFcc(event.target)" + resource="rdf:*" SpecialFolder="rdf:http://home.netscape.com/NC-rdf#SpecialFolder" Plus: add MessageFcc(event.target) on the root menuitem; change MessageFcc to use getAttribute("resource"); instead of id. Note: I arbitrarily chose "resource" as the attribute name, feel free to use a different name.
Assignee | ||
Comment 23•17 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008012001 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) Av1-SM, with comment 22 update; and a rewrite of the function, by using early returns. (In reply to comment #22) > I'm sure you can work it out from these hints: Thanks, it helped me (to get all the pieces together the right way) !
Attachment #298128 -
Flags: superreview?(neil)
Attachment #298128 -
Flags: review?(neil)
Assignee | ||
Updated•17 years ago
|
Attachment #297072 -
Attachment is obsolete: true
Comment 24•17 years ago
|
||
Comment on attachment 298128 [details] [diff] [review] (Bv1-SM) <messengercompose.xul> ++ >+ msgCompFields.fcc2 = "nocopy://"; This "nocopy://" is weird. I wonder why we use it. As far as we can tell, the only reason we check for it is to set it back to blank again. I'll file a bug. >+ dump("FCC2: " + fccUri + "\n"); Let me find out whether we still want these dump()s.
Attachment #298128 -
Flags: superreview?(neil)
Attachment #298128 -
Flags: superreview+
Attachment #298128 -
Flags: review?(neil)
Attachment #298128 -
Flags: review+
Comment 25•17 years ago
|
||
(In reply to comment #24) >(From update of attachment 298128 [details] [diff] [review]) >>+ dump("FCC2: " + fccUri + "\n"); >Let me find out whether we still want these dump()s. No we don't, thanks.
Assignee | ||
Comment 26•17 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008012001 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) Bv1-SM, with comment 25 update; and a little more rewrite(s).
Attachment #298128 -
Attachment is obsolete: true
Attachment #298190 -
Flags: superreview?(neil)
Attachment #298190 -
Flags: review?(neil)
Assignee | ||
Comment 27•17 years ago
|
||
(In reply to comment #24) > (From update of attachment 298128 [details] [diff] [review]) > >+ msgCompFields.fcc2 = "nocopy://"; > This "nocopy://" is weird. I wonder why we use it. As far as we can tell, the (That's how I felt too, but I didn't even try to look into that matter.) > only reason we check for it is to set it back to blank again. I'll file a bug. (You filed bug 413256 ;-))
Keywords: helpwanted
Updated•17 years ago
|
Attachment #298190 -
Flags: superreview?(neil)
Attachment #298190 -
Flags: superreview+
Attachment #298190 -
Flags: review?(neil)
Attachment #298190 -
Flags: review+
Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Whiteboard: [c-n: Bv1a-SM]
Assignee | ||
Comment 28•17 years ago
|
||
Bv1a-SM port/copy to TB.
Attachment #298984 -
Flags: review?(philringnalda)
Comment 29•17 years ago
|
||
Checking in mailnews/compose/resources/content/MsgComposeCommands.js; /cvsroot/mozilla/mailnews/compose/resources/content/MsgComposeCommands.js,v <-- MsgComposeCommands.js new revision: 1.409; previous revision: 1.408 done Checking in mailnews/compose/resources/content/messengercompose.xul; /cvsroot/mozilla/mailnews/compose/resources/content/messengercompose.xul,v <-- messengercompose.xul new revision: 1.297; previous revision: 1.296 done
Keywords: checkin-needed
Whiteboard: [c-n: Bv1a-SM]
Comment 30•17 years ago
|
||
Comment on attachment 298984 [details] [diff] [review] (Cv1-TB) <messengercompose.xul> ++ [Checkin: Comment 31] r=philringnalda, thanks.
Attachment #298984 -
Flags: review?(philringnalda) → review+
Comment 31•17 years ago
|
||
Checking in mail/components/compose/content/MsgComposeCommands.js; /cvsroot/mozilla/mail/components/compose/content/MsgComposeCommands.js,v <-- MsgComposeCommands.js new revision: 1.123; previous revision: 1.122 done Checking in mail/components/compose/content/messengercompose.xul; /cvsroot/mozilla/mail/components/compose/content/messengercompose.xul,v <-- messengercompose.xul new revision: 1.113; previous revision: 1.112 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Attachment #298190 -
Attachment description: (Bv1a-SM) <messengercompose.xul> ++ → (Bv1a-SM) <messengercompose.xul> ++
[Checkin: Comment 29]
Assignee | ||
Updated•17 years ago
|
Attachment #298984 -
Attachment description: (Cv1-TB) <messengercompose.xul> ++ → (Cv1-TB) <messengercompose.xul> ++
[Checkin: Comment 31]
Assignee | ||
Comment 32•17 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008012302 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) Trivial.
Attachment #299420 -
Flags: superreview?(neil)
Attachment #299420 -
Flags: review?(neil)
Assignee | ||
Comment 33•17 years ago
|
||
Dv1-SM port/copy to TB, plus whitespace cleanup/sync.
Attachment #299421 -
Flags: review?(philringnalda)
Assignee | ||
Comment 34•17 years ago
|
||
To update comment 0, I checked out the SeaMonkeyMailNews cvs module (and did some "grep -l -z" + manual search): List of |oncommand=| left to be moved: mailnews/base/resources/content/mailWindowOverlay.xul lots of mailnews/base/resources/content/msgFolderPickerOverlay.xul lots of mailnews/base/search/resources/content/FilterListDialog.xul 3 in 1 template xpinstall/res/content/updateNotification.xul 1 at ligne 25 The <xpinstall/> file is now unused, isn't it ?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [SergeG: Don't R.Fixed this bug; I'll do it...]
Assignee | ||
Updated•17 years ago
|
Status: REOPENED → ASSIGNED
Updated•17 years ago
|
Attachment #299420 -
Flags: superreview?(neil)
Attachment #299420 -
Flags: superreview+
Attachment #299420 -
Flags: review?(neil)
Attachment #299420 -
Flags: review+
Comment 35•17 years ago
|
||
(In reply to comment #34) >The <xpinstall/> file is now unused, isn't it ? It's outside of the scope of this bug anyway.
Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Whiteboard: [SergeG: Don't R.Fixed this bug; I'll do it...] → [c-n: Dv1-SM] [SergeG> Don't R.Fixed this bug; I'll do it...]
Assignee | ||
Comment 36•17 years ago
|
||
(In reply to comment #34) > mailnews/base/search/resources/content/FilterListDialog.xul 3 in 1 template [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008012802 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) Neil, I started to test |<menulist id="serverMenu" ...|: Selecting: *Local/Pop3 account: triggers line 110 (uri); fine. *A newsgroup: triggers line 83 (uri); fine. *Nntp account, with no children: triggers nothing; is it fine ? *Nntp account, "this news server": triggers line 91 (uri) then line 83 (blank); odd ! See "1.67 scott%scott-macgregor.org 2004-04-18 22:15 fix for bug #19403". Are the behaviors of the 2 last ones correct ? If not, how to fix them ?
Comment 37•17 years ago
|
||
Checking in mailnews/base/search/resources/content/ABSearchDialog.xul; /cvsroot/mozilla/mailnews/base/search/resources/content/ABSearchDialog.xul,v <-- ABSearchDialog.xul new revision: 1.19; previous revision: 1.18 done
Keywords: checkin-needed
Whiteboard: [c-n: Dv1-SM] [SergeG> Don't R.Fixed this bug; I'll do it...] → [SergeG> Don't R.Fixed this bug; I'll do it...]
Comment 38•17 years ago
|
||
(In reply to comment #36) > I started to test |<menulist id="serverMenu" ...|: > Selecting: > *Local/Pop3 account: triggers line 110 (uri); fine. > *A newsgroup: triggers line 83 (uri); fine. > *Nntp account, with no children: triggers nothing; is it fine ? > *Nntp account, "this news server": triggers line 91 (uri) then line 83 (blank); > odd ! > > Are the behaviors of the 2 last ones correct ? > If not, how to fix them ? > First, I should say that I think this needs to be replaced by a tree-like widget such as the one used in the advanced search dialog (note that I don't expect you to do that). The last behaviour isn't exactly correct, it appears to be an attempt to reduce the number of event handlers - notice that there are no event handlers in the <rule nc:ServerType="nntp"> section. The third behaviour isn't exactly correct either, but it depends on what you expect for a news server without any subscribed groups.
Assignee | ||
Updated•17 years ago
|
Attachment #299420 -
Attachment description: (Dv1-SM) <ABSearchDialog.xul> → (Dv1-SM) <ABSearchDialog.xul>
[Checkin: Comment 37]
Assignee | ||
Comment 39•17 years ago
|
||
(In reply to comment #34) > xpinstall/res/content/updateNotification.xul 1 at ligne 25 (In reply to comment #35) > (In reply to comment #34) > >The <xpinstall/> file is now unused, isn't it ? > It's outside of the scope of this bug anyway. Bug 406807 removed that file yesterday ;-)
Assignee | ||
Comment 40•17 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008013002 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) Killing 2 birds with one stone: *Fixes current bug. *"Fixes" behavior on (both) NNTP _server_ items, by "backing out" most of what bug 19403 did to these files. Example of previously bad behavior: Having a NNTP server without groups, opening the filter dialog from it would load its filters, while selecting it in the dialog list would not.
Attachment #300788 -
Flags: superreview?(neil)
Attachment #300788 -
Flags: review?(neil)
Assignee | ||
Comment 41•17 years ago
|
||
(In reply to comment #38) > First, I should say that I think this needs to be replaced by a tree-like > widget such as the one used in the advanced search dialog (note that I don't > expect you to do that). It seems that change will be done in bug 413781 or a followup. Yet, I think it's better to fix the current bug on its own (first). > The last behaviour isn't exactly correct, it appears to be an attempt to reduce > the number of event handlers - notice that there are no event handlers in the > <rule nc:ServerType="nntp"> section. > > The third behaviour isn't exactly correct either, but it depends on what you > expect for a news server without any subscribed groups. I'm not familiar with bug 19403 new feature, but I believe the current code(s) is broken. See bug 19403 comment 9, as an hint: [ Scott MacGregor 2004-04-18 10:24:40 PST // XXX this "!itemURI" thing is a hack // we come into onFilterServerClick twice // and when you choose a news server, and the second time it is "" if (!itemURI || itemURI == gCurrentServerURI) ]
Assignee | ||
Comment 42•17 years ago
|
||
Fv1-SM port/copy to TB.
Attachment #300790 -
Flags: review?(philringnalda)
Comment 43•17 years ago
|
||
Comment on attachment 300788 [details] [diff] [review] (Fv1-SM) <FilterListDialog.*> (+ NNTP server fix) > label="rdf:http://home.netscape.com/NC-rdf#Name"> Can you add an itemUri to this menu too please, to work around a bug/feature in up/down key handling in menulists, thanks.
Attachment #300788 -
Flags: superreview?(neil)
Attachment #300788 -
Flags: superreview+
Attachment #300788 -
Flags: review?(neil)
Attachment #300788 -
Flags: review+
Assignee | ||
Comment 44•17 years ago
|
||
Fv1-SM, with comment 43 update. Restores selecting a NNTP server with children with keyboard, which previous patch would have removed. NB: Selecting a child/newsgroup by keyboard is still impossible. I guess this is (partly) why Neil spoke of "tree" in comment 38...
Attachment #300788 -
Attachment is obsolete: true
Assignee | ||
Comment 45•17 years ago
|
||
Fv1a-SM port/copy to TB.
Attachment #300790 -
Attachment is obsolete: true
Attachment #301014 -
Flags: review?(philringnalda)
Attachment #300790 -
Flags: review?(philringnalda)
Assignee | ||
Comment 46•17 years ago
|
||
(In reply to comment #44) > NB: Selecting a child/newsgroup by keyboard is still impossible. "... without opening the dropdown (Alt+Down) first", I mean :-> (In reply to comment #43) > [...] to work around a bug/feature in up/down key handling in menulists, thanks. Is that a filed "bug" ? (The closest bug I found is bug 302060, but it doesn't seem to be the same issue.)
Keywords: checkin-needed
Whiteboard: [SergeG> Don't R.Fixed this bug; I'll do it...] → [c-n: Fv1a-SM] [SergeG> Don't R.Fixed this bug; I'll do it...]
Comment 47•17 years ago
|
||
Checking in mailnews/base/search/resources/content/FilterListDialog.js; /cvsroot/mozilla/mailnews/base/search/resources/content/FilterListDialog.js,v <-- FilterListDialog.js new revision: 1.69; previous revision: 1.68 done Checking in mailnews/base/search/resources/content/FilterListDialog.xul; /cvsroot/mozilla/mailnews/base/search/resources/content/FilterListDialog.xul,v <-- FilterListDialog.xul new revision: 1.71; previous revision: 1.70 done
Keywords: checkin-needed
Whiteboard: [c-n: Fv1a-SM] [SergeG> Don't R.Fixed this bug; I'll do it...] → [SergeG> Don't R.Fixed this bug; I'll do it...]
Assignee | ||
Updated•17 years ago
|
Attachment #301013 -
Attachment description: (Fv1a-SM) <FilterListDialog.*> (+ NNTP server fix) → (Fv1a-SM) <FilterListDialog.*> (+ NNTP server fix)
[Checkin: Comment 47]
Assignee | ||
Comment 48•17 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008020202 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) That's 7 times the "same" template, which has 6 rules: *1 & 2 items are disabled, then don't care. *3 & 6 are updated :-) *4 is empty, then don't care. *5 seems good as it is, but I'm not sure what its "test case" is. Can you confirm that I understood it well enough ? *** Then, 2 |oncommand="MsgGetMessagesForAccount(event)"| remain. They are mixed with other |command="..."| and |oncommand="..."|. Can you give me some "hints" on how to "merge" them, or I'll leave it to someone else...
Attachment #301128 -
Flags: superreview?(neil)
Attachment #301128 -
Flags: review?(neil)
Assignee | ||
Updated•17 years ago
|
Attachment #301014 -
Flags: review?(bienvenu)
Assignee | ||
Updated•17 years ago
|
Attachment #299421 -
Flags: review?(bienvenu)
Assignee | ||
Updated•17 years ago
|
Blocks: 413781
Summary: remove event handlers from within <template> → Remove event handlers from within <template> (mail/ and mailnews/ part)
Comment 49•17 years ago
|
||
(In reply to comment #48) >*5 seems good as it is, but I'm not sure what its "test case" is. >Can you confirm that I understood it well enough ? Rule 5 seems to be for accounts (I don't understand why rule 1 doesn't have the same content as rule 5). >Then, 2 |oncommand="MsgGetMessagesForAccount(event)"| remain. >They are mixed with other |command="..."| and |oncommand="..."|. Wow, what a headache... I'm not even sure that works properly :-\
Updated•17 years ago
|
Attachment #301128 -
Flags: superreview?(neil)
Attachment #301128 -
Flags: superreview+
Attachment #301128 -
Flags: review?(neil)
Attachment #301128 -
Flags: review+
Updated•17 years ago
|
Attachment #299421 -
Flags: review?(philringnalda) → review+
Updated•17 years ago
|
Attachment #301014 -
Flags: review?(philringnalda) → review+
Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Whiteboard: [SergeG> Don't R.Fixed this bug; I'll do it...] → [c-n: Ev1-TB, Gv1a-TB], [SergeG> Don't R.Fixed this bug; I'll do it...]
Assignee | ||
Updated•17 years ago
|
Attachment #301014 -
Flags: review?(bienvenu)
Assignee | ||
Updated•17 years ago
|
Attachment #299421 -
Flags: review?(bienvenu)
Comment 50•17 years ago
|
||
Checking in mail/base/content/ABSearchDialog.xul; /cvsroot/mozilla/mail/base/content/ABSearchDialog.xul,v <-- ABSearchDialog.xul new revision: 1.18; previous revision: 1.17 done Checking in mail/base/content/FilterListDialog.js; /cvsroot/mozilla/mail/base/content/FilterListDialog.js,v <-- FilterListDialog.js new revision: 1.14; previous revision: 1.13 done Checking in mail/base/content/FilterListDialog.xul; /cvsroot/mozilla/mail/base/content/FilterListDialog.xul,v <-- FilterListDialog.xul new revision: 1.6; previous revision: 1.5 done
Keywords: checkin-needed
Whiteboard: [c-n: Ev1-TB, Gv1a-TB], [SergeG> Don't R.Fixed this bug; I'll do it...] → [SergeG> Don't R.Fixed this bug; I'll do it...]
Assignee | ||
Updated•17 years ago
|
Attachment #299421 -
Attachment description: (Ev1-TB) <ABSearchDialog.xul> → (Ev1-TB) <ABSearchDialog.xul>
[Checkin: Comment 50]
Assignee | ||
Updated•17 years ago
|
Attachment #301014 -
Attachment description: (Gv1a-TB) <FilterListDialog.*> (+ NNTP server fix) → (Gv1a-TB) <FilterListDialog.*> (+ NNTP server fix)
[Checkin: Comment 50]
Assignee | ||
Comment 51•17 years ago
|
||
(Not worth creating a separate bug.) *"MsgMoveMessage" -> "MoveMessageInSearch", in |dump()| statement. This code is created/blamed to [ 1.33 gayatrib%netscape.com 2001-03-24 01:08 Implementing deleting/filing messages on single and multiple folders in search. Fixed regression introduced after merging performance branch that search does not display number of search hits. r=bhuvan,bienvenu. sr=bienvenu. ]
Attachment #302295 -
Flags: superreview?(neil)
Attachment #302295 -
Flags: review?(neil)
Comment 52•17 years ago
|
||
Comment on attachment 302295 [details] [diff] [review] (Iv1) <SearchDialog.js> "MsgMoveMessage" related nit I don't think it's worth it... also that 6-space indentation is wrong, and you should have used the -p option when making the patch.
Attachment #302295 -
Flags: superreview?(neil)
Attachment #302295 -
Flags: review?(neil)
Attachment #302295 -
Flags: review-
Assignee | ||
Comment 53•16 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008040902 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) Hv1-SM, extended after bug 416669. Keeping sr+. The only difference in these (7) new occurrences is that the "outer" |oncommand=| implicitly applies to the (new) "inner" menus too.
Attachment #301128 -
Attachment is obsolete: true
Attachment #314595 -
Flags: review?(neil)
Assignee | ||
Comment 54•16 years ago
|
||
(In reply to comment #53) > Created an attachment (id=314595) [details] > (Hv1a-SM) <mailWindowOverlay.xul> (1/2: Copy+File+Move) > > [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008040902 > SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) PS: While testing this patch, I noticed that in the Thread and Message panes (at least ! Not in Menu and Toolbar ?), I could get the two recent (IMAP) folders I was testing with to: sometimes show up as 'folder - account' (as "always" in the Menu and Toolbar), sometimes show up as 'folder' only. For now, I assume this is an "issue / inconsistency" in the "datasource" and unrelated to this front-end patch(es).
Updated•16 years ago
|
Attachment #314595 -
Flags: review?(neil) → review+
Updated•16 years ago
|
Product: Core → MailNews Core
Comment 56•14 years ago
|
||
does "1/2" imply is there a part 2 yet to be done for mailwindowOverlay for thunderbird?
Assignee | ||
Comment 57•14 years ago
|
||
(In reply to comment #56) > does "1/2" imply is there a part 2 yet to be done for mailwindowOverlay for > thunderbird? As you wrote in your email to me: yes, I'm waiting for bug 444913 to be fixed before trying to resume work here.
Updated•5 years ago
|
Comment 58•5 years ago
|
||
The template this bug was about has been removed since long.
Status: NEW → RESOLVED
Closed: 17 years ago → 5 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•