right now we have the impl requirement that the listener impl nsIWeakReference. this should be reflected by replacing nsISupports w/ nsIWeakReference in the method signature.

This all looks good, except that you should prefer direct-initialization over copy-initialization, that is, prefer constructions nsCOMPtr<nsIWeakReference> listener(do_QueryInterface(...)); // ... nsCOMPtr<nsIWeakReference> thisListener(do_QueryInterface(listener)); over the form with '='. After you fix that, sr=scc.

I've updated the patches as the direct QI to a nsIWeakReference was failing. I needed to be using NS_GetWeakReference (which I now am). I've also added a patch to viewer so it can use the new mechanism as well.

More evidence, I guess, that I really need to provide a |do_GetWeakReference|. This still isn't right. To get a weak reference you need to say nsCOMPtr<nsIWeakReference> weakling( dont_AddRef(NS_GetWeakReference(...)) );

Now I buy it. One of us should file a bug, though, that |do_GetWeakReference| is wanted. sr=scc

The patch to CBrowserShell.cpp in patch id=25206 didn't quite compile - now it does.

thanks for the mac check conrad. these changes (including conrad's mods) are in.

Correction: Changing QA contact for the Embed API bugs to David Epstein.

in nsIWebBrowser.idl, we see that the listener accepts a weak reference: void addWebBrowserListener(in nsIWeakReference aListener, in nsIIDRef aIID);