Closed Bug 682420 Opened 13 years ago Closed 13 years ago

Rename nsINode::GetOwnerDoc to nsINode::OwnerDoc

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(8 files, 1 obsolete file)

s/GetOwnerDoc()/OwnerDoc()/
(deleted), patch
jst
: review+
Details | Diff | Splinter Review
Remove useless null checks
(deleted), patch
jst
: review+
Details | Diff | Splinter Review
-w
(deleted), patch
Details | Diff | Splinter Review
s/GetOwnerDoc()/OwnerDoc()/, up-to-date
(deleted), patch
Details | Diff | Splinter Review
Remove useless null checks, up-to-date
(deleted), patch
Details | Diff | Splinter Review
backout for 10, part 1
(deleted), patch
Details | Diff | Splinter Review
backout for 10, part 2
(deleted), patch
Details | Diff | Splinter Review
backout strongparent node from 10
(deleted), patch
Details | Diff | Splinter Review
Assignee: nobody → Olli.Pettay
Attached patch initial patch (obsolete) (deleted) — — Splinter Review
...but I think I should remove some unneeded null checks while I'm changing the code.
Attached patch s/GetOwnerDoc()/OwnerDoc()/ (deleted) — — Splinter Review
This is script generated patch, but I had to fix few whitespace issues manually when the change was done inside a macro. Another patch coming which will remove some null checks.
Attachment #567366 - Attachment is obsolete: true
Attachment #567405 - Flags: review?
Attachment #567405 - Flags: review? → review?(jst)
Attached patch Remove useless null checks (deleted) — — Splinter Review
Uploaded to try. There can be still some more useless null checks, but this should cover most common cases.
Attachment #567429 - Flags: review?(jst)
Attached patch -w (deleted) — — Splinter Review
Attachment #567405 - Flags: review?(jst) → review+
Attachment #567429 - Flags: review?(jst) → review+
s/PR_TRUE/true/ patch caused quite a few merging problems.
Attached patch backout for 10, part 1 (deleted) — — Splinter Review
Just in case we want to backout strong parent node from 10...
Attached patch backout for 10, part 2 (deleted) — — Splinter Review
This patch is really not for this bug, but want to back it up somewhere. And it is needed if we want to have non-strong-parent in 10.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: